From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40456) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bygza-00046Z-1c for qemu-devel@nongnu.org; Mon, 24 Oct 2016 11:16:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bygzZ-0007HU-Af for qemu-devel@nongnu.org; Mon, 24 Oct 2016 11:16:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36394) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bygzZ-0007Gx-4M for qemu-devel@nongnu.org; Mon, 24 Oct 2016 11:16:49 -0400 Date: Mon, 24 Oct 2016 09:16:47 -0600 From: Alex Williamson Message-ID: <20161024091647.1ef0a8fe@t450s.home> In-Reply-To: <4e5b9816-d845-a502-8737-572b0cb638b8@redhat.com> References: <20161021171100.18049.96340.stgit@gimli.home> <7c882719-507a-daf1-6c90-25cdd11b9ac4@gmx.de> <20161022090955.41762256@t450s.home> <4e5b9816-d845-a502-8737-572b0cb638b8@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH] memory: Don't use memcpy for ram marked as skip_dump List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Thorsten Kohfeldt , qemu-devel@nongnu.org On Mon, 24 Oct 2016 13:05:56 +0200 Paolo Bonzini wrote: > On 22/10/2016 17:09, Alex Williamson wrote: > > > Add a trace message for each mrop. > > > > Yes, this is on my todo list post-RFC. > > Another thing to think about: > > 1) rename all the skip_dump occurrences in the API to device_memory. > The new ops make it much more specific than just skipping the region > during dumps. > > 2) get rid of mr->skip_dump and check mr->ops == &skip_dump_ops (or > device_memory_ops) instead. Yep, I like those ideas. Thanks, Alex