From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55354) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bysOP-00026s-Ak for qemu-devel@nongnu.org; Mon, 24 Oct 2016 23:27:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bysOO-00018R-Cf for qemu-devel@nongnu.org; Mon, 24 Oct 2016 23:27:13 -0400 Date: Tue, 25 Oct 2016 14:23:41 +1100 From: David Gibson Message-ID: <20161025032341.GS11052@umbus.fritz.box> References: <1477285483-10766-1-git-send-email-david@gibson.dropbear.id.au> <20161025025002.GQ11052@umbus.fritz.box> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4ECF1u7dKBoUGhe3" Content-Disposition: inline In-Reply-To: <20161025025002.GQ11052@umbus.fritz.box> Subject: Re: [Qemu-devel] [PATCHv3 00/12] pseries: Consolidate guest device tree construction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: aik@ozlabs.ru, mdroth@linux.vnet.ibm.com, groug@kaod.org Cc: agraf@suse.de, lvivier@redhat.com, thuth@redhat.com, qemu-ppc@nongnu.org, qemu-devel@nongnu.org, bharata@linux.vnet.ibm.com --4ECF1u7dKBoUGhe3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Oct 25, 2016 at 01:50:02PM +1100, David Gibson wrote: > On Mon, Oct 24, 2016 at 04:04:31PM +1100, David Gibson wrote: > > For historical reasons construction of the guest device tree in spapr > > is divided between spapr_create_fdt_skel() which is called at init > > time, and spapr_build_fdt() which runs at reset time. Over time, more > > and more things have needed to be moved to reset time. > >=20 > > This series consolidates all the device tree construction to reset > > time, with some minor cleanups along the way. This will help to make > > it more maintainable in future. > >=20 > > Changes since v2: > > * Removed a leftover reference to a variable called 'stdout', > > shadowing the standard library stdout > > Changes since v1: > > * Fixed a memory leak introduced by 1/12 (spotted by Thomas Huth) > > * Removed one patch that's already merged in ppc-for-2.8 >=20 > Thanks for the acks, everyone. I've now merged this series into > ppc-for-2.8, tentatively. >=20 > Bharata Rao reported some boot failures caused by the series, but I > haven't been able to reproduce them so far. Bharata, could you retest > with the latest version (in ppc-for-2.8) and, if the problems are > still present, send me some reproducer steps. Actually, I just realised the bug Bharata reported looks identical to one someone else spotted. That was caused by one of Thomas' NVRAM cleanups, rather than the DT cleanup. It's already been removed from ppc-for-2.8 pending debug. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --4ECF1u7dKBoUGhe3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYDtA6AAoJEGw4ysog2bOSWN0QAIsr8kY/OelAlJOI+JSA3x3j HvWdjVQ3CuSfEomfdHiG2mQrjK96JK2en1+P8vbrkvy3y7AhuPwAvJYxIl1xUYOM mr8GoN/KuBIPoqUxN4p8cUHB76qH74rdVPHGRcDRX3insdhEdcJnUgi+5nJIQ4a9 8dirLQIMYS6I1bi19Wi7QBX2ENWtKNFCtlXWTQSlZkh6Ju3TzeCY1lpUt4K1ka02 Bn2woCzZ0a0vnfZ6htBn42yf8R8wood2BBgM6++steyeFFXy3kYl9GqzZo8VqE8X Db32jF1+PxHSwIU5KmstOd7/j2xezipKXSW0zcJMDHyG4gfEhh/pvp9N6E1vRUHT BZujr38oA4e3E+3Sm+lDrbyCq2eZvwYVLwbNQtMWxF8HH1XTc/2gcg7yZUP/Yx1Q q/TOCgwk/Rb6qIlHjb0tKKZIJpU0ldJm6J6vYiF5+TDByymPKJs+1zNKnrIHTXK3 RPX1EJg5dw86iXjDOMUp7TPxYzUtgv/nDR/ZOENt0zM8zMPwvIqI3gJv6QvAN+tZ 3AcQ7W70wUtdf4bSP0bt9ALuuIWeuAFEBe7eWYtE0V46uhtj9MPi6PupsVW5g/jY aOD/+Bn1vwxnoP/9mMT7zWYSPVtT2taRASmE4eRwH0E4iJb0bm3fvOYYL3ZlHYTE eYJ0WAw6G0xf4waGuGmz =RVlq -----END PGP SIGNATURE----- --4ECF1u7dKBoUGhe3--