From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51584) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1byukh-0006FR-Qj for qemu-devel@nongnu.org; Tue, 25 Oct 2016 01:58:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1byukh-0006bm-4T for qemu-devel@nongnu.org; Tue, 25 Oct 2016 01:58:23 -0400 Date: Tue, 25 Oct 2016 13:58:15 +0800 From: Fam Zheng Message-ID: <20161025055815.GD5427@lemon> References: <1475237406-26917-1-git-send-email-famz@redhat.com> <1475237406-26917-16-git-send-email-famz@redhat.com> <92388e72-ef6f-56b7-3869-32e0d657d5da@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <92388e72-ef6f-56b7-3869-32e0d657d5da@redhat.com> Subject: Re: [Qemu-devel] [PATCH v8 15/36] qdev: Add "lock-mode" to block device options List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: qemu-devel@nongnu.org, Kevin Wolf , qemu-block@nongnu.org, Jeff Cody , rjones@redhat.com, Markus Armbruster , stefanha@redhat.com, pbonzini@redhat.com, den@openvz.org, John Snow On Sat, 10/22 02:11, Max Reitz wrote: > On 30.09.2016 14:09, Fam Zheng wrote: > > Signed-off-by: Fam Zheng > > --- > > hw/core/qdev-properties.c | 10 ++++++++++ > > include/hw/block/block.h | 1 + > > include/hw/qdev-properties.h | 3 +++ > > 3 files changed, 14 insertions(+) > > Why don't you add _conf.lock_mode in this very patch (instead of patch > 3) and pull it in front of patch 12? Setting the mode won't do anything > until it's implemented for the various block devices, but I don't think > that's a bad thing. Sounds good! Fam