From: Kevin Wolf <kwolf@redhat.com>
To: Ashijeet Acharya <ashijeetacharya@gmail.com>
Cc: rjones@redhat.com, jcody@redhat.com, mreitz@redhat.com,
eblake@redhat.com, berrange@redhat.com, pbonzini@redhat.com,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 3/5] block/ssh: Add InetSocketAddress and accept it
Date: Tue, 25 Oct 2016 11:55:45 +0200 [thread overview]
Message-ID: <20161025095545.GD4695@noname.str.redhat.com> (raw)
In-Reply-To: <1476725535-3350-4-git-send-email-ashijeetacharya@gmail.com>
Am 17.10.2016 um 19:32 hat Ashijeet Acharya geschrieben:
> Add InetSocketAddress compatibility to SSH driver.
>
> Add a new option "server" to the SSH block driver which then accepts
> a InetSocketAddress.
>
> "host" and "port" are supported as legacy options and are mapped to
> their InetSocketAddress representation.
>
> Signed-off-by: Ashijeet Acharya <ashijeetacharya@gmail.com>
> @@ -603,12 +661,21 @@ static int connect_to_ssh(BDRVSSHState *s, QDict *options,
> host_key_check = "yes";
> }
>
> - /* Construct the host:port name for inet_connect. */
> - g_free(s->hostport);
> - s->hostport = g_strdup_printf("%s:%d", host, port);
s->hostport isn't set any more now, so it should be removed from
BDRVSSHState. There is one user left, a warning message in
unsafe_flush_warning(), which should be converted to access s->inet
instead.
Kevin
next prev parent reply other threads:[~2016-10-25 9:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-17 17:32 [Qemu-devel] [PATCH v3 0/5] Allow blockdev-add for SSH Ashijeet Acharya
2016-10-17 17:32 ` [Qemu-devel] [PATCH v3 1/5] block/ssh: Add ssh_has_filename_options_conflict() Ashijeet Acharya
2016-10-25 10:03 ` Kevin Wolf
2016-10-17 17:32 ` [Qemu-devel] [PATCH v3 2/5] util/qemu-sockets: Make inet_connect_saddr() public Ashijeet Acharya
2016-10-25 10:03 ` Kevin Wolf
2016-10-17 17:32 ` [Qemu-devel] [PATCH v3 3/5] block/ssh: Add InetSocketAddress and accept it Ashijeet Acharya
2016-10-25 9:55 ` Kevin Wolf [this message]
2016-10-17 17:32 ` [Qemu-devel] [PATCH v3 4/5] block/ssh: Use InetSocketAddress options Ashijeet Acharya
2016-10-25 10:04 ` Kevin Wolf
2016-10-17 17:32 ` [Qemu-devel] [PATCH v3 5/5] qapi: allow blockdev-add for ssh Ashijeet Acharya
2016-10-25 10:04 ` Kevin Wolf
2016-10-25 19:52 ` Eric Blake
2016-10-17 18:51 ` [Qemu-devel] [PATCH v3 0/5] Allow blockdev-add for SSH no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161025095545.GD4695@noname.str.redhat.com \
--to=kwolf@redhat.com \
--cc=ashijeetacharya@gmail.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=jcody@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).