From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33377) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1byySY-0004sp-KG for qemu-devel@nongnu.org; Tue, 25 Oct 2016 05:55:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1byySX-00034z-Lh for qemu-devel@nongnu.org; Tue, 25 Oct 2016 05:55:54 -0400 Date: Tue, 25 Oct 2016 11:55:45 +0200 From: Kevin Wolf Message-ID: <20161025095545.GD4695@noname.str.redhat.com> References: <1476725535-3350-1-git-send-email-ashijeetacharya@gmail.com> <1476725535-3350-4-git-send-email-ashijeetacharya@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1476725535-3350-4-git-send-email-ashijeetacharya@gmail.com> Subject: Re: [Qemu-devel] [PATCH v3 3/5] block/ssh: Add InetSocketAddress and accept it List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ashijeet Acharya Cc: rjones@redhat.com, jcody@redhat.com, mreitz@redhat.com, eblake@redhat.com, berrange@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org Am 17.10.2016 um 19:32 hat Ashijeet Acharya geschrieben: > Add InetSocketAddress compatibility to SSH driver. > > Add a new option "server" to the SSH block driver which then accepts > a InetSocketAddress. > > "host" and "port" are supported as legacy options and are mapped to > their InetSocketAddress representation. > > Signed-off-by: Ashijeet Acharya > @@ -603,12 +661,21 @@ static int connect_to_ssh(BDRVSSHState *s, QDict *options, > host_key_check = "yes"; > } > > - /* Construct the host:port name for inet_connect. */ > - g_free(s->hostport); > - s->hostport = g_strdup_printf("%s:%d", host, port); s->hostport isn't set any more now, so it should be removed from BDRVSSHState. There is one user left, a warning message in unsafe_flush_warning(), which should be converted to access s->inet instead. Kevin