From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55068) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bz2nE-0003sm-7f for qemu-devel@nongnu.org; Tue, 25 Oct 2016 10:33:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bz2nA-00071Z-CZ for qemu-devel@nongnu.org; Tue, 25 Oct 2016 10:33:32 -0400 Date: Tue, 25 Oct 2016 16:33:20 +0200 From: Kevin Wolf Message-ID: <20161025143320.GJ4695@noname.str.redhat.com> References: <1477337274-7939-1-git-send-email-ashijeetacharya@gmail.com> <1477337274-7939-3-git-send-email-ashijeetacharya@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1477337274-7939-3-git-send-email-ashijeetacharya@gmail.com> Subject: Re: [Qemu-devel] [PATCH v2 2/2] qapi: allow blockdev-add for NFS List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ashijeet Acharya Cc: pl@kamp.de, jcody@redhat.com, mreitz@redhat.com, armbru@redhat.com, eblake@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org Am 24.10.2016 um 21:27 hat Ashijeet Acharya geschrieben: > Introduce new object 'BlockdevOptionsNFS' in qapi/block-core.json to > support blockdev-add for NFS network protocol driver. Also make a new > struct NFSServer to support tcp connection. > > Signed-off-by: Ashijeet Acharya > --- > qapi/block-core.json | 56 ++++++++++++++++++++++++++++++++++++++++++++++++---- > 1 file changed, 52 insertions(+), 4 deletions(-) > > diff --git a/qapi/block-core.json b/qapi/block-core.json > index 9d797b8..3ab028d 100644 > --- a/qapi/block-core.json > +++ b/qapi/block-core.json > @@ -1714,9 +1714,9 @@ > { 'enum': 'BlockdevDriver', > 'data': [ 'archipelago', 'blkdebug', 'blkverify', 'bochs', 'cloop', > 'dmg', 'file', 'ftp', 'ftps', 'gluster', 'host_cdrom', > - 'host_device', 'http', 'https', 'luks', 'null-aio', 'null-co', > - 'parallels', 'qcow', 'qcow2', 'qed', 'quorum', 'raw', > - 'replication', 'tftp', 'vdi', 'vhdx', 'vmdk', 'vpc', 'vvfat' ] } > + 'host_device', 'http', 'https', 'luks', 'nfs', 'null-aio', > + 'null-co', 'parallels', 'qcow', 'qcow2', 'qed', 'quorum', 'raw', > + 'replication', 'tftp', 'vdi', 'vhdx', 'vmdk', 'vpc', 'vvfat' ] } > > ## > # @BlockdevOptionsFile > @@ -2212,6 +2212,54 @@ > '*top-id': 'str' } } > > ## > +# @NFSServer > +# > +# Captures the address of the socket > +# > +# @type: transport type used for NFS (only TCP supported) > +# > +# @host: host part of the address > +# > +# Since 2.8 > +## > +{ 'struct': 'NFSServer', > + 'data': { 'type': 'str', > + 'host': 'str' } } > + > +## > +# @BlockdevOptionsNfs > +# > +# Driver specific block device option for NFS > +# > +# @server: host address > +# > +# @path: path of the image on the host > +# > +# @uid: #optional UID value to use when talking to the server > +# > +# @gid: #optional GID value to use when talking to the server > +# > +# @tcp-syncnt: #optional number of SYNs during the session establishment > +# > +# @readahead: #optional set the readahead size in bytes > +# > +# @pagecache: #optional set the pagecache size in bytes > +# > +# @debug: #optional set the NFS debug level (max 2) > +# > +# Since 2.8 > +## > +{ 'struct': 'BlockdevOptionsNfs', > + 'data': { 'server': 'NFSServer', Patch 1 doesn't handle "server.type" and "server.host", so does this actually work? > + 'path': 'str', > + '*uid': 'int', > + '*gid': 'int', > + '*tcp-syncnt': 'int', > + '*readahead': 'int', > + '*pagecache': 'int', > + '*debug': 'int' } } > + > +## > # @BlockdevOptionsCurl > # > # Driver specific block device options for the curl backend. Kevin