From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58258) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bz3ye-0001te-2s for qemu-devel@nongnu.org; Tue, 25 Oct 2016 11:49:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bz3yZ-0002xz-So for qemu-devel@nongnu.org; Tue, 25 Oct 2016 11:49:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52682) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bz3yZ-0002uc-Mz for qemu-devel@nongnu.org; Tue, 25 Oct 2016 11:49:19 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D747EBB1B for ; Tue, 25 Oct 2016 15:49:17 +0000 (UTC) Date: Tue, 25 Oct 2016 17:49:14 +0200 From: "Daniel P. Berrange" Message-ID: <20161025154914.GA17307@redhat.com> Reply-To: "Daniel P. Berrange" References: <1477406107-10757-1-git-send-email-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1477406107-10757-1-git-send-email-armbru@redhat.com> Subject: Re: [Qemu-devel] [PATCH RFC 0/3] Rename of the QObject visitors rearranged List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, kwolf@redhat.com, eblake@redhat.com On Tue, Oct 25, 2016 at 04:35:04PM +0200, Markus Armbruster wrote: > This is how I propose to rearrange PATCH 04+05 of Dan's "[PATCH v14 > 00/21] QAPI/QOM work for non-scalar object properties" (really v15) in > my pull request, to make git's rename detection work. The result is > identical except for two comments I touched up: > > diff --git a/include/qapi/qobject-output-visitor.h b/include/qapi/qobject-output-visitor.h > index 358c959..8241877 100644 > --- a/include/qapi/qobject-output-visitor.h > +++ b/include/qapi/qobject-output-visitor.h > @@ -20,7 +20,7 @@ > typedef struct QObjectOutputVisitor QObjectOutputVisitor; > > /* > - * Create a new QOBJECT output visitor. > + * Create a new QObject output visitor. > * > * If everything else succeeds, pass @result to visit_complete() to > * collect the result of the visit. > diff --git a/qapi/qobject-output-visitor.c b/qapi/qobject-output-visitor.c > index df43cb8..8711270 100644 > --- a/qapi/qobject-output-visitor.c > +++ b/qapi/qobject-output-visitor.c > @@ -150,7 +150,7 @@ static void qobject_output_type_int64(Visitor *v, const char *name, > static void qobject_output_type_uint64(Visitor *v, const char *name, > uint64_t *obj, Error **errp) > { > - /* FIXME: QOBJECT outputs values larger than INT64_MAX as negative */ > + /* FIXME values larger than INT64_MAX become negative */ > QObjectOutputVisitor *qov = to_qov(v); > qobject_output_add(qov, name, qint_from_int(*obj)); > } Looks fine to me. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|