From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45689) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bzGAh-0004ev-Ib for qemu-devel@nongnu.org; Wed, 26 Oct 2016 00:50:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bzGAf-0004jy-00 for qemu-devel@nongnu.org; Wed, 26 Oct 2016 00:50:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39510) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bzGAe-0004jl-Md for qemu-devel@nongnu.org; Wed, 26 Oct 2016 00:50:36 -0400 Date: Wed, 26 Oct 2016 10:20:32 +0530 From: Amit Shah Message-ID: <20161026045032.GC1679@amit-lp.rh> References: <1476792613-11712-1-git-send-email-zhang.zhanghailiang@huawei.com> <1476792613-11712-4-git-send-email-zhang.zhanghailiang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1476792613-11712-4-git-send-email-zhang.zhanghailiang@huawei.com> Subject: Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 03/17] migration: Enter into COLO mode after migration if COLO is enabled List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: zhanghailiang Cc: quintela@redhat.com, qemu-devel@nongnu.org, dgilbert@redhat.com, wency@cn.fujitsu.com, lizhijian@cn.fujitsu.com, xiecl.fnst@cn.fujitsu.com, Gonglei On (Tue) 18 Oct 2016 [20:09:59], zhanghailiang wrote: > Add a new migration state: MIGRATION_STATUS_COLO. Migration source side > enters this state after the first live migration successfully finished > if COLO is enabled by command 'migrate_set_capability x-colo on'. > > We reuse migration thread, so the process of checkpointing will be handled > in migration thread. > > Signed-off-by: zhanghailiang > Signed-off-by: Li Zhijian > Signed-off-by: Gonglei > Reviewed-by: Dr. David Alan Gilbert (snip) > +static void colo_process_checkpoint(MigrationState *s) > +{ > + qemu_mutex_lock_iothread(); > + vm_start(); > + qemu_mutex_unlock_iothread(); > + trace_colo_vm_state_change("stop", "run"); > + > + /* TODO: COLO checkpoint savevm loop */ > + > + migrate_set_state(&s->state, MIGRATION_STATUS_COLO, > + MIGRATION_STATUS_COMPLETED); Is this just a temporary thing that'll be removed in the next patches? I guess so - because once you enter COLO state, you want to remain in it, right? I think the commit message implies that. So the commit msg and the code are not in sync. (snip) > diff --git a/migration/migration.c b/migration/migration.c > index f7dd9c6..462007d 100644 > --- a/migration/migration.c > +++ b/migration/migration.c > @@ -695,6 +695,10 @@ MigrationInfo *qmp_query_migrate(Error **errp) > > get_xbzrle_cache_stats(info); > break; > + case MIGRATION_STATUS_COLO: > + info->has_status = true; > + /* TODO: display COLO specific information (checkpoint info etc.) */ > + break; When do you plan to add this? I guess it's important for debugging and also to get the state of the system while colo is active. What info do you have planned to display here? Amit