From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57923)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1bzJL7-0001zU-Qx
	for qemu-devel@nongnu.org; Wed, 26 Oct 2016 04:13:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1bzJL7-0002CD-3a
	for qemu-devel@nongnu.org; Wed, 26 Oct 2016 04:13:37 -0400
Date: Wed, 26 Oct 2016 10:13:28 +0200
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20161026081328.GD4758@noname.str.redhat.com>
References: <cover.1477234224.git.tgolembi@redhat.com>
	<e5caa2b75e9168909aa3951cd3a4928bfed16e20.1477234224.git.tgolembi@redhat.com>
	<20161025233733.4a0e2a67@fiorina>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20161025233733.4a0e2a67@fiorina>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v5] raw_bsd: add offset and size options
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?utf-8?B?VG9tw6HFoSBHb2xlbWJpb3Zza8O9?= <tgolembi@redhat.com>
Cc: qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>, Markus Armbruster <armbru@redhat.com>, Eric Blake <eblake@redhat.com>, "Daniel P . Berrange" <berrange@redhat.com>, qemu-block@nongnu.org

Am 25.10.2016 um 23:37 hat Tom=C3=A1=C5=A1 Golembiovsk=C3=BD geschrieben:
> I should test my code more before submitting it to ML. I have found two
> bugs in the patch.

Maybe one thing you could/should do is add a second patch which adds a
qemu-iotests case to test that the options are working correctly.

Kevin