From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49180)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <prvs=1002ef6c0=wei.liu2@citrix.com>)
	id 1bzLW3-0005lp-Br
	for qemu-devel@nongnu.org; Wed, 26 Oct 2016 06:33:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <prvs=1002ef6c0=wei.liu2@citrix.com>)
	id 1bzLVy-0002wt-H4
	for qemu-devel@nongnu.org; Wed, 26 Oct 2016 06:33:03 -0400
Received: from smtp02.citrix.com ([66.165.176.63]:56309)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71)
	(envelope-from <prvs=1002ef6c0=wei.liu2@citrix.com>)
	id 1bzLVy-0002w5-Ba
	for qemu-devel@nongnu.org; Wed, 26 Oct 2016 06:32:58 -0400
Date: Wed, 26 Oct 2016 11:32:56 +0100
From: Wei Liu <wei.liu2@citrix.com>
Message-ID: <20161026103255.GG30231@citrix.com>
References: <1477416484-29054-1-git-send-email-wei.liu2@citrix.com>
	<alpine.DEB.2.10.1610251631290.9978@sstabellini-ThinkPad-X260>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.10.1610251631290.9978@sstabellini-ThinkPad-X260>
Subject: Re: [Qemu-devel] [PATCH RFC] acpi: don't build acpi tables for xen
 hvm guests
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Wei Liu <wei.liu2@citrix.com>, qemu-devel@nongnu.org, Xen-devel <xen-devel@lists.xenproject.org>, Anthony PERARD <anthony.perard@citrix.com>, mst@redhat.com, pbonzini@redhat.com, rth@twiddle.net, ehabkost@redhat.com

On Tue, Oct 25, 2016 at 04:33:03PM -0700, Stefano Stabellini wrote:
> CC'ing maintainers
> 
> On Tue, 25 Oct 2016, Wei Liu wrote:
> > Xen's toolstack is in charge of building ACPI tables. Skip acpi table
> > building if running on Xen.
> > 
> > This issue is discovered due to direct kernel boot on Xen doesn't boot
> > anymore, because the new ACPI tables cause the guest to exceed its
> > memory allocation limit.
> > 
> > Reported-by: Sander Eikelenboom <linux@eikelenboom.it>
> > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> 
> Hi Wei,
> thanks for the patch. I think the right fix is to set
> 
> pcmc->has_acpi_build = false
> 
> for the xenfv machine and for the PC machine when accel=xen.
> 
> Thoughts?
> 

This sounds like a better idea to me.

Wei.