From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41646) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bzMcQ-0007D6-Ql for qemu-devel@nongnu.org; Wed, 26 Oct 2016 07:43:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bzMcL-0004Tf-SA for qemu-devel@nongnu.org; Wed, 26 Oct 2016 07:43:42 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:57100) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bzMcL-0004SB-GS for qemu-devel@nongnu.org; Wed, 26 Oct 2016 07:43:37 -0400 Date: Wed, 26 Oct 2016 13:43:35 +0200 From: Samuel Thibault Message-ID: <20161026114335.GB2811@var.bordeaux.inria.fr> References: <20161015195308.20473-1-samuel.thibault@ens-lyon.org> <20161025222616.GE2801@var.home> <1477476355.18984.32.camel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1477476355.18984.32.camel@redhat.com> Subject: Re: [Qemu-devel] [PATCH 0/5] curses: wide character support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org, pbonzini@redhat.com, berrange@redhat.com, peter.maydell@linaro.org, mjt@tls.msk.ru Hello, Gerd Hoffmann, on Wed 26 Oct 2016 12:05:55 +0200, wrote: > Back online now after being sick for a while. Oh, sorry about that, hoping you're fine. > > Samuel Thibault, on Sat 15 Oct 2016 21:53:03 +0200, wrote: > > > This patch series adds wide character support to the curses frontend of qemu, > > > thus allowing to fix a lot of input and output issues with e.g. accented letters > > > and semi-graphic glyphs. Since qemu can't know the encoding of the VGA font, the > > > user has to specify it (just like he has to specify the keyboard layout with > > > -k). I used option -f to make it simple for now, but I welcome any other idea :) > > > > I forgot to mention that I updated the patches according to the reviews > > on the list (assume cursesw support, and use -display option). > > Good, looks much better now without all the #ifdefs. > > /me wonders whenever we should do the same with iconv. It's part of the > POSIX.1-2001 specs, and we have 2016 now. Do we *really* need configure > checks and #ifdefs for it? I would only say that libiconv is not always installed by default on BSD systems for instance. > Also we could use iconv for the cp437-to-unicode mapping instead of > having a hard-coded table for it. Ah, indeed. > Given how close the freeze deadline is now I'm tempted to cherry-pick > patches 0-3 and prepare a pull request ASAP. You mean patches 1-3? Patch 5 would be very useful too to fix typing accented letters, and it doesn't depend on patch 4. Thanks, Samuel