From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51442) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bzbm0-0007z2-QA for qemu-devel@nongnu.org; Wed, 26 Oct 2016 23:54:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bzblx-0007dy-OJ for qemu-devel@nongnu.org; Wed, 26 Oct 2016 23:54:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56824) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bzblx-0007de-JD for qemu-devel@nongnu.org; Wed, 26 Oct 2016 23:54:33 -0400 Date: Thu, 27 Oct 2016 09:24:28 +0530 From: Amit Shah Message-ID: <20161027035428.GB1476@amit-lp.rh> References: <1476792613-11712-1-git-send-email-zhang.zhanghailiang@huawei.com> <1476792613-11712-18-git-send-email-zhang.zhanghailiang@huawei.com> <20161026060746.GQ1679@amit-lp.rh> <79ca80e4-e13a-c0bf-c7d9-ec6cf0f8c7df@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <79ca80e4-e13a-c0bf-c7d9-ec6cf0f8c7df@redhat.com> Subject: Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 17/17] configure: Support enable/disable COLO feature List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: zhanghailiang , xiecl.fnst@cn.fujitsu.com, lizhijian@cn.fujitsu.com, quintela@redhat.com, qemu-devel@nongnu.org, dgilbert@redhat.com, Gonglei On (Wed) 26 Oct 2016 [08:42:27], Eric Blake wrote: > On 10/26/2016 01:07 AM, Amit Shah wrote: > > On (Tue) 18 Oct 2016 [20:10:13], zhanghailiang wrote: > >> configure --enable-colo/--disable-colo to switch COLO > >> support on/off. > >> COLO feature is enabled by default. > >> > >> Signed-off-by: zhanghailiang > >> Signed-off-by: Li Zhijian > >> Signed-off-by: Gonglei > >> Reviewed-by: Dr. David Alan Gilbert > > > > Reviewed-by: Amit Shah > > > >> v19: > >> - fix colo_supported() to return true > >> v11: > >> - Turn COLO on in default (Eric's suggestion) > > > > Can you recap why the suggestion was made to switch it on by default? > > If the feature doesn't depend on external libraries, then enabling > compilation by default will avoid bitrot. Yes, that's fair, thanks. > But mentioning this rationale in the commit message never hurts :) Yep! Amit