From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41491)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1bzgSQ-0004p2-H7
	for qemu-devel@nongnu.org; Thu, 27 Oct 2016 04:54:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1bzgSM-0003F3-Ko
	for qemu-devel@nongnu.org; Thu, 27 Oct 2016 04:54:42 -0400
Date: Thu, 27 Oct 2016 09:54:33 +0100
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Message-ID: <20161027085432.GA2033@work-vm>
References: <20161011174121.815-1-marcandre.lureau@redhat.com>
	<87a8ea693q.fsf@dusky.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <87a8ea693q.fsf@dusky.pond.sub.org>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCHv2] monitor: deprecate 'default' option
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>, qemu-trivial@nongnu.org
Cc: =?iso-8859-1?Q?Marc-Andr=E9?= Lureau <marcandre.lureau@redhat.com>, qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>

* Markus Armbruster (armbru@redhat.com) wrote:
> Marc-Andr=E9 Lureau <marcandre.lureau@redhat.com> writes:
>=20
> > This option does nothing since commit 06ac27f.  Deprecate it.
> >
> > Signed-off-by: Marc-Andr=E9 Lureau <marcandre.lureau@redhat.com>
> > ---
> >  vl.c                      | 11 +++--------
> >  include/monitor/monitor.h |  2 +-
> >  qemu-options.hx           |  8 ++++----
> >  3 files changed, 8 insertions(+), 13 deletions(-)
> >
> > v2:
> >  - update after Markus review
> >  - fix error on default monitor
> >  - drop from qemu-trivial
>=20
> Suggest to squash in the appended patch.
>=20
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
>=20
> Could go via David, Paolo or myself.  David, do you have anything
> pending right now?

I said I'd take this via the HMP tree, but I've not got anything else
to go in after 2 weeks, and it's pointless doing a pull on it's own
for this.

It seems best to go via trivial - (copied in).

Dave

>=20
> diff --git a/monitor.c b/monitor.c
> index b07f254..ab9e911 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -4093,7 +4093,7 @@ QemuOptsList qemu_mon_opts =3D {
>              .name =3D "chardev",
>              .type =3D QEMU_OPT_STRING,
>          },{
> -            .name =3D "default",
> +            .name =3D "default",  /* deprecated */
>              .type =3D QEMU_OPT_BOOL,
>          },{
>              .name =3D "pretty",
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK