From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35177) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bzkcw-0004XV-6u for qemu-devel@nongnu.org; Thu, 27 Oct 2016 09:21:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bzkcs-0002Ng-4H for qemu-devel@nongnu.org; Thu, 27 Oct 2016 09:21:50 -0400 Date: Thu, 27 Oct 2016 20:26:31 +1100 From: David Gibson Message-ID: <20161027092631.GQ19918@umbus.fritz.box> References: <1477534830-25495-1-git-send-email-mdroth@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="DCA/C9WSnDtl50zu" Content-Disposition: inline In-Reply-To: <1477534830-25495-1-git-send-email-mdroth@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH v3 0/6] spapr: dedicated hotplug events and memory unplug support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org, bharata@linux.vnet.ibm.com, nfont@linux.vnet.ibm.com, jallen@linux.vnet.ibm.com --DCA/C9WSnDtl50zu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 26, 2016 at 09:20:24PM -0500, Michael Roth wrote: > This series is based on David's ppc-for-2.8 branch, and is also available= from: >=20 > https://github.com/mdroth/qemu/commits/spapr-hotplug-event-update Looks like a merged a little prematurely. I've replaced the v2 patches in ppc-for-2.8 with this updated version. >=20 > Changes since v2: > * Rebased on latest ppc-for-2.8 > * Fix silly screw up with Reviewed-by attributions >=20 > Changes since v1: > * Rebased on latest ppc-for-2.8 > * Dropped patches relating to option vector manipulation (now merged) > * Moved patch introducing modern-hotplug-events option to come after > that actual implementation of modern-hotplug-events support. (David) > * Removed uneeded source name string from sPAPREventSource in favor of > manual lookup of the name when creating DT. (David) > * Don't split function return signatures across lines (David) > * Add comment to clarify hotplug events being enabled regardless > of CAS-negotiation. > * Avoid unecessary initialization of hotplug_ctrl in > spapr_lmb_release. (David) >=20 > Changes since RFC: > * Rebased on latest ppc-for-2.8 (with DT refactoring) > * Submitting as v1 now that PAPR Hotplug ACR is committed > * address Patchew warnings > * add comments to clarify spapr->ov5/ov5_cas usage. (David) > * revise comment to clarify intent when setting spapr->ov5 > OV5_HP_EVT bit. (Bharata) > * drop internal usage of spapr_ovec_from_bitmap() in favor of > directly assigning bitmap to sPAPROptionVector instances. (David) > * standardize meaning of 'vector_len' variable through spapr_ovec_* > functions to be the byte-wise length of option vectors entries, > and not including the preceeding length byte itself. (David) > * fix spapr_ovec_populate_dt() to parse up to OV_MAXBITS bits > rather than OV_MAXBITS - 1. (David) > * fix spapr_ovec_populate_dt() encode the minimum of 1 option > vector byte instead of the max of OV_MAXBYTES in cases where > no option bits are set. (David) > * add some comments to spapr_ovec_populate_dt() to clarify what > is being encoded into length byte of ibm,architecture-vec-5 > * switch 'legacy-hotplug-events' option to > 'modern-hotplug-events' (David) > * modify rtas_event_log_to_source() to check for OV5_HP_EVT > option rather than relying on whether the hotplug source is > specifically enabled. Assert the latter in cases where > OV5_HP_EVT is set. (Bharata) > * drop global EventSource list in favor of an sPAPREventSource > list field within sPAPRMachineState (David) > * add CPU unplug hook in mc->unplug_request (Bharata) >=20 > Patches 1-4 add support for an updated event format for hotplug events, > which includes a new way to specify a range of DRCs/LMBs to hotplug/unplug > using a starting position and count, which is necessary for memory unplug. >=20 > Patches 5-6 add support for memory unplug using the new event format. >=20 > In addition to kernel 4.8 or later, there are a number of patches required > to enable support on the guest kernel side. I've including the minimum set > of patches in my branch here: >=20 > https://github.com/mdroth/linux/commits/spapr-hotplug-event-update >=20 > *powerpc/pseries: advertise Hot Plug Event support to firmware > powerpc/pseries: Implement indexed-count hotplug memory remove > powerpc/pseries: Implement indexed-count hotplug memory add >=20 > Note that there is currently an issue that arises when attempting to > offline an LMB that was onlined using a guest kernel's auto-onlining > mechanism, which can prevent full completion of memory unplug requests. > This is being investigated, but for the purposes of testing this can > be worked around currently by disabling auto-onlining in guests via: >=20 > "echo offline >/sys/devices/system/memory/auto_online_blocks" >=20 > and instead onlining the blocks manually or via udev. >=20 > docs/specs/ppc-spapr-hotplug.txt | 55 +++++++++++++++++++++----- > hw/ppc/spapr.c | 178 +++++++++++++++++++++++++++++++++= ++++++++++++++++++++++++++++++++++++++++++++++---- > hw/ppc/spapr_drc.c | 17 ++++++++ > hw/ppc/spapr_events.c | 278 +++++++++++++++++++++++++++++++++= ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---= ---------------------- > include/hw/ppc/spapr.h | 10 ++++- > include/hw/ppc/spapr_ovec.h | 1 + > 6 files changed, 469 insertions(+), 70 deletions(-) >=20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --DCA/C9WSnDtl50zu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYEchEAAoJEGw4ysog2bOSwSUQALeiygvc9IfRV8qDS1QOEoiZ MVYgWmE8DYr9VV8EHfdElntBoVfLnHQYIAwx5NoVmCZUKSqlrozMRpev/zUddD+Y PVqKSDFRjAuXkUPKBRcURY28ixiwLdvr2SEKbBSNBGqTypGaI4mi/ToJsaC9NHUo +xtVi1SUEsMEuLq5uXj32qJkdjy50Ik4UvknvmsCTKanjDQGbW5L8FknlvT2w+n+ ZQDpPKaFKzAvlOIVwsS3nAnmOekvdPH28XWto4BIkVmfSxPc1qR8pQ4zcknwCDJt TmSEOpyKrd5DrvzNr2AVds2yI+pdBq5OX06M7wMap6/zlb+5pKwlRRYrQC6sjmbS ZtBU5tnbeoxXuys2dcag7PqosGxaOHdTcgeddKLKdz7m1dvzepJfNdhhvAPDQq/K uxKBfdeojmUL3bgG1x1fOTbdBHosvAqwtb9jTIm6Ge/7c8wcX09vXnO2daailJqb Fnl4dtn0nszbOX6n1317gei3Fj19+qRmk8T7LurmCz8P6RY3cstRnjRp6bljqo9Y XO7uMUwnWeeJSeOPZsRzFwoknqZ/Vg6GhmTYnL+UtK7/9VFju4MsYbfvfWLQE7LX /zcgFajxEuwXwGhEcLTrVPmQzVyo8M2RQr5IFytnf0tk7epCAx+xUU0gTxPVL5FA XyyYqDbBFMpWPlDVzsuC =kUus -----END PGP SIGNATURE----- --DCA/C9WSnDtl50zu--