From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51185) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bzlQk-0007Qh-Vy for qemu-devel@nongnu.org; Thu, 27 Oct 2016 10:13:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bzlQg-0002xi-NN for qemu-devel@nongnu.org; Thu, 27 Oct 2016 10:13:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33728) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bzlQg-0002xG-Hw for qemu-devel@nongnu.org; Thu, 27 Oct 2016 10:13:14 -0400 Date: Thu, 27 Oct 2016 16:13:10 +0200 From: Igor Mammedov Message-ID: <20161027161310.3da02bfb@nial.brq.redhat.com> In-Reply-To: <1477499426-9550-2-git-send-email-ehabkost@redhat.com> References: <1477499426-9550-1-git-send-email-ehabkost@redhat.com> <1477499426-9550-2-git-send-email-ehabkost@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 1/8] tests: check-qom-proplist: Remove duplicate "bv" property List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: qemu-devel@nongnu.org, Markus Armbruster , Andreas =?UTF-8?B?RsOkcmJlcg==?= , "Daniel P. Berrange" On Wed, 26 Oct 2016 14:30:19 -0200 Eduardo Habkost wrote: > The object_property_add_bool() call in dummy_init() is always > failing because there is an existing "bv" class property. We need > to remove either the "bv" class property or the "bv" instance > property. > > Remove the class property so both object properties and class > properties are covered by the test code. > > Signed-off-by: Eduardo Habkost Reviewed-by: Igor Mammedov > --- > Changes series v2 -> v3: > * Reworded commit message for clarity > --- > tests/check-qom-proplist.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/tests/check-qom-proplist.c b/tests/check-qom-proplist.c > index a16cefc..693dc4c 100644 > --- a/tests/check-qom-proplist.c > +++ b/tests/check-qom-proplist.c > @@ -129,10 +129,6 @@ static void dummy_init(Object *obj) > > static void dummy_class_init(ObjectClass *cls, void *data) > { > - object_class_property_add_bool(cls, "bv", > - dummy_get_bv, > - dummy_set_bv, > - NULL); > object_class_property_add_str(cls, "sv", > dummy_get_sv, > dummy_set_sv,