From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52141) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bzlUA-0000Ru-P1 for qemu-devel@nongnu.org; Thu, 27 Oct 2016 10:16:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bzlU6-0004A7-K6 for qemu-devel@nongnu.org; Thu, 27 Oct 2016 10:16:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60832) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bzlU6-00049i-EY for qemu-devel@nongnu.org; Thu, 27 Oct 2016 10:16:46 -0400 Date: Thu, 27 Oct 2016 16:16:43 +0200 From: Igor Mammedov Message-ID: <20161027161643.12b42230@nial.brq.redhat.com> In-Reply-To: <1477499426-9550-3-git-send-email-ehabkost@redhat.com> References: <1477499426-9550-1-git-send-email-ehabkost@redhat.com> <1477499426-9550-3-git-send-email-ehabkost@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 2/8] tests: check-qom-proplist: Use &error_abort to catch errors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: qemu-devel@nongnu.org, Markus Armbruster , Andreas =?UTF-8?B?RsOkcmJlcg==?= , "Daniel P. Berrange" On Wed, 26 Oct 2016 14:30:20 -0200 Eduardo Habkost wrote: > Use &error_abort so we don't ignore any errors on the property > registration calls. a similar patch for other *property_add* calls in that file would be nice addition on top, so *property_add* calls would be treated consistently. >=20 > Reviewed-by: Andreas F=C3=A4rber > Signed-off-by: Eduardo Habkost Reviewed-by: Igor Mammedov > --- > tests/check-qom-proplist.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/tests/check-qom-proplist.c b/tests/check-qom-proplist.c > index 693dc4c..a92acc9 100644 > --- a/tests/check-qom-proplist.c > +++ b/tests/check-qom-proplist.c > @@ -123,7 +123,7 @@ static void dummy_init(Object *obj) > object_property_add_bool(obj, "bv", > dummy_get_bv, > dummy_set_bv, > - NULL); > + &error_abort); > } > =20 > =20 > @@ -132,13 +132,13 @@ static void dummy_class_init(ObjectClass *cls, void= *data) > object_class_property_add_str(cls, "sv", > dummy_get_sv, > dummy_set_sv, > - NULL); > + &error_abort); > object_class_property_add_enum(cls, "av", > "DummyAnimal", > dummy_animal_map, > dummy_get_av, > dummy_set_av, > - NULL); > + &error_abort); > } > =20 > =20