From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34895) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bzm1y-0006su-TQ for qemu-devel@nongnu.org; Thu, 27 Oct 2016 10:51:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bzm1u-0005GK-U9 for qemu-devel@nongnu.org; Thu, 27 Oct 2016 10:51:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55794) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bzm1u-0005Fs-Nz for qemu-devel@nongnu.org; Thu, 27 Oct 2016 10:51:42 -0400 Date: Thu, 27 Oct 2016 16:51:39 +0200 From: Igor Mammedov Message-ID: <20161027165139.2a6e630f@nial.brq.redhat.com> In-Reply-To: <1477499426-9550-6-git-send-email-ehabkost@redhat.com> References: <1477499426-9550-1-git-send-email-ehabkost@redhat.com> <1477499426-9550-6-git-send-email-ehabkost@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 5/8] qdev: Register static properties as class properties List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: qemu-devel@nongnu.org, Markus Armbruster , Andreas =?UTF-8?B?RsOkcmJlcg==?= , "Daniel P. Berrange" On Wed, 26 Oct 2016 14:30:23 -0200 Eduardo Habkost wrote: > Instead of registering qdev static properties on instance_init, > register them as class properties, at qdev_class_set_props(). > > qdev_property_add_legacy() was replaced by an equivalent > qdev_class_property_add_legacy() function. > qdev_property_add_static(), on the other hand, can't be > eliminated yet because it is used by arm_cpu_post_init(). > > Signed-off-by: Eduardo Habkost > --- > Changes series v1 -> v2: > * (none) > > Changes v2 -> v3: > * Fix code alignemnt > * Reported-by: Igor Mammedov > --- > hw/core/qdev.c | 71 ++++++++++++++++++++++++++++++++++++++++++++++++---------- > 1 file changed, 59 insertions(+), 12 deletions(-) > > diff --git a/hw/core/qdev.c b/hw/core/qdev.c > index 85952e8..a88753c 100644 > --- a/hw/core/qdev.c > +++ b/hw/core/qdev.c > @@ -739,12 +739,12 @@ static void qdev_get_legacy_property(Object *obj, Visitor *v, > } > > /** > - * qdev_property_add_legacy: > - * @dev: Device to add the property to. > + * qdev_class_property_add_legacy: > + * @oc: Device to add the property to. s/Device/Class/ > * @prop: The qdev property definition. > * @errp: location to store error information. > * > - * Add a legacy QOM property to @dev for qdev property @prop. > + * Add a legacy QOM property to @oc for qdev property @prop. > * On error, store error in @errp. > * > * Legacy properties are string versions of QOM properties. The format of [...] "make V=1 check" fails for me with this patch applied: QTEST_QEMU_BINARY=aarch64-softmmu/qemu-system-aarch64 QTEST_QEMU_IMG=qemu-img MALLOC_PERTURB_=${MALLOC_PERTURB_:-$((RANDOM % 255 + 1))} gtester -k --verbose -m=quick tests/device-introspect-test tests/qom-test TEST: tests/device-introspect-test... (pid=275141) /aarch64/device/introspect/list: OK /aarch64/device/introspect/none: OK /aarch64/device/introspect/abstract: OK /aarch64/device/introspect/concrete: Unexpected error in object_property_find() at /home/imammedo/builds/qemu/qom/object.c:1002: Property '.disable_vnet_hdr' not found Broken pipe FAIL GTester: last random seed: R02Se62da1d190b80e3301072daa8e4eab92 (pid=275152) FAIL: tests/device-introspect-test TEST: tests/qom-test... (pid=275153)