From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36196) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c082g-0007iP-ME for qemu-devel@nongnu.org; Fri, 28 Oct 2016 10:21:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c082f-0005S3-NO for qemu-devel@nongnu.org; Fri, 28 Oct 2016 10:21:58 -0400 Date: Fri, 28 Oct 2016 22:21:49 +0800 From: Fam Zheng Message-ID: <20161028142149.GD8431@lemon> References: <1477596278-1470-1-git-send-email-ppandit@redhat.com> <147766342608.143.15390303781959856001@9040ca97f87d> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <147766342608.143.15390303781959856001@9040ca97f87d> Subject: Re: [Qemu-devel] [PATCH v4] char: cadence: check baud rate generator and divider values List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: ppandit@redhat.com, peter.maydell@linaro.org, pjp@fedoraproject.org, alistair.francis@xilinx.com, qemu-arm@nongnu.org, edgar.iglesias@gmail.com, psirt@huawei.com On Fri, 10/28 07:03, no-reply@patchew.org wrote: > In file included from /usr/x86_64-w64-mingw32/sys-root/mingw/lib/glib-2.0/include/glibconfig.h:9:0, > from /usr/x86_64-w64-mingw32/sys-root/mingw/include/glib-2.0/glib/gtypes.h:32, > from /usr/x86_64-w64-mingw32/sys-root/mingw/include/glib-2.0/glib/galloca.h:32, > from /usr/x86_64-w64-mingw32/sys-root/mingw/include/glib-2.0/glib.h:30, > from /tmp/qemu-test/src/include/glib-compat.h:19, > from /tmp/qemu-test/src/include/qemu/osdep.h:107, > from trace/generated-tracers.c:3: > trace/generated-tracers.c: In function '_simple_trace_visit_type_str': > trace/generated-tracers.c:50123:42: error: passing argument 1 of 'strlen' from incompatible pointer type [-Werror=incompatible-pointer-types] > size_t argobj_len = obj ? MIN(strlen(obj), MAX_TRACE_STRLEN) : 0; > ^ > /usr/x86_64-w64-mingw32/sys-root/mingw/include/glib-2.0/glib/gmacros.h:291:23: note: in definition of macro 'MIN' > #define MIN(a, b) (((a) < (b)) ? (a) : (b)) > ^ > In file included from /tmp/qemu-test/src/include/qemu/osdep.h:69:0, > from trace/generated-tracers.c:3: > /usr/x86_64-w64-mingw32/sys-root/mingw/include/string.h:55:18: note: expected 'const char *' but argument is of type 'char **' > size_t __cdecl strlen(const char *_Str); > ^~~~~~ > In file included from /usr/x86_64-w64-mingw32/sys-root/mingw/lib/glib-2.0/include/glibconfig.h:9:0, > from /usr/x86_64-w64-mingw32/sys-root/mingw/include/glib-2.0/glib/gtypes.h:32, > from /usr/x86_64-w64-mingw32/sys-root/mingw/include/glib-2.0/glib/galloca.h:32, > from /usr/x86_64-w64-mingw32/sys-root/mingw/include/glib-2.0/glib.h:30, > from /tmp/qemu-test/src/include/glib-compat.h:19, > from /tmp/qemu-test/src/include/qemu/osdep.h:107, > from trace/generated-tracers.c:3: > trace/generated-tracers.c:50123:42: error: passing argument 1 of 'strlen' from incompatible pointer type [-Werror=incompatible-pointer-types] > size_t argobj_len = obj ? MIN(strlen(obj), MAX_TRACE_STRLEN) : 0; > ^ > /usr/x86_64-w64-mingw32/sys-root/mingw/include/glib-2.0/glib/gmacros.h:291:36: note: in definition of macro 'MIN' > #define MIN(a, b) (((a) < (b)) ? (a) : (b)) > ^ > In file included from /tmp/qemu-test/src/include/qemu/osdep.h:69:0, > from trace/generated-tracers.c:3: > /usr/x86_64-w64-mingw32/sys-root/mingw/include/string.h:55:18: note: expected 'const char *' but argument is of type 'char **' > size_t __cdecl strlen(const char *_Str); > ^~~~~~ > trace/generated-tracers.c:50134:34: error: passing argument 2 of 'trace_record_write_str' from incompatible pointer type [-Werror=incompatible-pointer-types] > trace_record_write_str(&rec, obj, argobj_len); > ^~~ > In file included from trace/generated-tracers.c:17892:0: > /tmp/qemu-test/src/trace/simple.h:42:6: note: expected 'const char *' but argument is of type 'char **' > void trace_record_write_str(TraceBufferRecord *rec, const char *s, uint32_t slen); > ^~~~~~~~~~~~~~~~~~~~~~ > cc1: all warnings being treated as errors > /tmp/qemu-test/src/rules.mak:60: recipe for target 'trace/generated-tracers.o' failed > make: *** [trace/generated-tracers.o] Error 1 > make[1]: *** [docker-run] Error 2 > make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-vo_8jsgn/src' > make: *** [docker-run-test-mingw@fedora] Error 2 > === OUTPUT END === You can ignore this one, it's not in this patch and is just fixed on master - the series was applied by patchew earlier than that. Fam