From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55606)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1c0SgX-0001wY-6G
	for qemu-devel@nongnu.org; Sat, 29 Oct 2016 08:24:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1c0SgS-0000ig-GB
	for qemu-devel@nongnu.org; Sat, 29 Oct 2016 08:24:29 -0400
Received: from mx1.redhat.com ([209.132.183.28]:41226)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <jcody@redhat.com>) id 1c0SgS-0000i1-AL
	for qemu-devel@nongnu.org; Sat, 29 Oct 2016 08:24:24 -0400
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id 9CF8985365
	for <qemu-devel@nongnu.org>; Sat, 29 Oct 2016 12:24:23 +0000 (UTC)
Date: Sat, 29 Oct 2016 08:24:21 -0400
From: Jeff Cody <jcody@redhat.com>
Message-ID: <20161029122421.GE17785@localhost.localdomain>
References: <1470736094-19194-1-git-send-email-prasanna.kalever@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1470736094-19194-1-git-send-email-prasanna.kalever@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v1 1/1] block/gluster: fix port type in the
 QAPI options list
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Cc: qemu-devel@nongnu.org, armbru@redhat.com, eblake@redhat.com, vbellur@redhat.com

On Tue, Aug 09, 2016 at 03:18:14PM +0530, Prasanna Kumar Kalever wrote:
> After introduction of qapi schema in gluster block driver code, the port
> type is now string as per InetSocketAddress
> 
> { 'struct': 'InetSocketAddress',
>   'data': {
>     'host': 'str',
>     'port': 'str',
>     '*to': 'uint16',
>     '*ipv4': 'bool',
>     '*ipv6': 'bool' } }
> 
> but the current code still treats it as QEMU_OPT_NUMBER, hence fixing port
> to accept QEMU_OPT_STRING.
> 
> Credits: Markus Armbruster <armbru@redhat.com>
> 
> Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
> ---
>  block/gluster.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/block/gluster.c b/block/gluster.c
> index edde1ad..e6afa48 100644
> --- a/block/gluster.c
> +++ b/block/gluster.c
> @@ -161,7 +161,7 @@ static QemuOptsList runtime_tcp_opts = {
>          },
>          {
>              .name = GLUSTER_OPT_PORT,
> -            .type = QEMU_OPT_NUMBER,
> +            .type = QEMU_OPT_STRING,
>              .help = "port number on which glusterd is listening (default 24007)",
>          },
>          {
> -- 
> 2.7.4
> 

Thanks,

Applied to my block branch:

git://github.com/codyprime/qemu-kvm-jtc.git block

[Changed 'Credits' to 'Suggested-by']

-Jeff