From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52245) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c10JH-0001at-Br for qemu-devel@nongnu.org; Sun, 30 Oct 2016 20:18:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c10JE-0002Nw-5B for qemu-devel@nongnu.org; Sun, 30 Oct 2016 20:18:43 -0400 Date: Mon, 31 Oct 2016 11:15:59 +1100 From: David Gibson Message-ID: <20161031001559.GC18226@umbus.fritz.box> References: <1477675084-7713-1-git-send-email-joserz@linux.vnet.ibm.com> <1477675084-7713-3-git-send-email-joserz@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="UPT3ojh+0CqEDtpF" Content-Disposition: inline In-Reply-To: <1477675084-7713-3-git-send-email-joserz@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH v2 2/4] target-ppc: Implement bcdctn. instruction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jose Ricardo Ziviani Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, nikunj@linux.vnet.ibm.com, bharata@linux.vnet.ibm.com --UPT3ojh+0CqEDtpF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 28, 2016 at 03:18:02PM -0200, Jose Ricardo Ziviani wrote: > bcdctn. converts from BCD to National numeric format. National format > uses a byte to represent a digit where the most significant nibble is > always 0x3 and the least sign. nibbles is the digit itself. >=20 > Signed-off-by: Jose Ricardo Ziviani > --- > target-ppc/helper.h | 1 + > target-ppc/int_helper.c | 48 +++++++++++++++++++++++++++++++= ++++++ > target-ppc/translate/vmx-impl.inc.c | 24 ++++++++++++++++++- > 3 files changed, 72 insertions(+), 1 deletion(-) >=20 > diff --git a/target-ppc/helper.h b/target-ppc/helper.h > index 3b23eed..53d1e7a 100644 > --- a/target-ppc/helper.h > +++ b/target-ppc/helper.h > @@ -372,6 +372,7 @@ DEF_HELPER_4(vpermxor, void, avr, avr, avr, avr) > DEF_HELPER_4(bcdadd, i32, avr, avr, avr, i32) > DEF_HELPER_4(bcdsub, i32, avr, avr, avr, i32) > DEF_HELPER_3(bcdcfn, i32, avr, avr, i32) > +DEF_HELPER_2(bcdctn, i32, avr, avr) > =20 > DEF_HELPER_2(xsadddp, void, env, i32) > DEF_HELPER_2(xssubdp, void, env, i32) > diff --git a/target-ppc/int_helper.c b/target-ppc/int_helper.c > index 9d620a6..a58ed30 100644 > --- a/target-ppc/int_helper.c > +++ b/target-ppc/int_helper.c > @@ -2506,6 +2506,15 @@ static uint8_t get_national_digit(ppc_avr_t *reg, = int n) > #endif > } > =20 > +static void set_national_digit(ppc_avr_t *reg, uint8_t val, int n) > +{ > +#if defined(HOST_WORDS_BIGENDIAN) > + reg->u16[8 - n] =3D val; > +#else > + reg->u16[n] =3D val; > +#endif > +} > + > static int bcd_cmp_mag(ppc_avr_t *a, ppc_avr_t *b) > { > int i; > @@ -2679,6 +2688,45 @@ uint32_t helper_bcdcfn(ppc_avr_t *r, ppc_avr_t *b,= uint32_t ps) > return cr; > } > =20 > +uint32_t helper_bcdctn(ppc_avr_t *r, ppc_avr_t *b) > +{ > + int i; > + int cr =3D 0; > + int sgnb =3D bcd_get_sgn(b); > + int invalid =3D (sgnb =3D=3D 0); > + ppc_avr_t ret =3D { .u64 =3D { 0, 0 } }; > + > + int eq_flag =3D (b->u64[HI_IDX] =3D=3D 0) && ((b->u64[LO_IDX] >> 4) = =3D=3D 0); > + int ox_flag =3D (b->u64[HI_IDX] !=3D 0) || ((b->u64[LO_IDX] >> 32) != =3D 0); > + > + for (i =3D 1; i < 8; i++) { > + set_national_digit(&ret, 0x30 + bcd_get_digit(b, i, &invalid), i= ); > + > + if (unlikely(invalid)) { > + break; > + } > + } > + set_national_digit(&ret, (sgnb =3D=3D -1) ? NATIONAL_NEG : NATIONAL_= PLUS, 0); > + > + if (!eq_flag) { > + cr =3D (sgnb =3D=3D -1) ? 1 << CRF_LT : 1 << CRF_GT; > + } else { > + cr =3D 1 << CRF_EQ; > + } > + > + if (ox_flag) { > + cr |=3D 1 << CRF_SO; > + } > + > + if (unlikely(invalid)) { > + cr =3D 1 << CRF_SO; > + } > + > + *r =3D ret; > + > + return cr; > +} > + > void helper_vsbox(ppc_avr_t *r, ppc_avr_t *a) > { > int i; > diff --git a/target-ppc/translate/vmx-impl.inc.c b/target-ppc/translate/v= mx-impl.inc.c > index 06d28f2..e37fc11 100644 > --- a/target-ppc/translate/vmx-impl.inc.c > +++ b/target-ppc/translate/vmx-impl.inc.c > @@ -968,9 +968,29 @@ static void gen_##op(DisasContext *ctx) \ > tcg_temp_free_i32(ps); \ > } > =20 > +#define GEN_BCD3(op) \ > +static void gen_##op(DisasContext *ctx) \ > +{ \ > + TCGv_ptr rb, rd; \ > + \ > + if (unlikely(!ctx->altivec_enabled)) { \ > + gen_exception(ctx, POWERPC_EXCP_VPU); \ > + return; \ > + } \ > + \ > + rb =3D gen_avr_ptr(rB(ctx->opcode)); \ > + rd =3D gen_avr_ptr(rD(ctx->opcode)); \ > + \ > + gen_helper_##op(cpu_crf[6], rd, rb); \ > + \ > + tcg_temp_free_ptr(rb); \ > + tcg_temp_free_ptr(rd); \ > +} I don't think it's worth bothering with another GEN macro here. Just use GEN_BCD2 and ignore the ps parameter in the helper function. > + > GEN_BCD(bcdadd) > GEN_BCD(bcdsub) > GEN_BCD2(bcdcfn) > +GEN_BCD3(bcdctn) > =20 > static void gen_xpnd04_1(DisasContext *ctx) > { > @@ -982,7 +1002,8 @@ static void gen_xpnd04_1(DisasContext *ctx) > case 4: > break; /* bcdctz. */ > case 5: > - break; /* bcdctn. */ > + gen_bcdctn(ctx); > + break; > case 6: > break; /* bcdcfz. */ > case 7: > @@ -1098,3 +1119,4 @@ GEN_VXFORM_DUAL(vsldoi, PPC_ALTIVEC, PPC_NONE, > #undef GEN_VAFORM_PAIRED > =20 > #undef GEN_BCD2 > +#undef GEN_BCD3 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --UPT3ojh+0CqEDtpF Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYFo05AAoJEGw4ysog2bOSnkEP/jadSY73GTqowVaslckwSF7L nJWbHLHRKKVAgBZrZWuIpjEC6+/JjaNKEkEbWaAcxbic3BCYBcVJgcpu5YevBrvs 1qKRjr2Y6FEXegJ2ZkKfhvy79UexPcnVpMZzfCme7U0C/CF2obl9ei+7s/Qn91vD SacyW9NUwLCT5LjKIgY8ZrWohv5hrJo8Sv/5xMJNEItmcGuDIm0EjRo0LkfHm55O vec+7VpBTwAOHIr10r7wE/0E/7s++8FdUb/BkE71Iobd6aJ5kFSDawS3Xvd8NvJU /vZLVPSvtNxTb9XpCWdztqlB0KiH+8IrtegnN39d9OMI7e7xnvaHuSBgEEYJWtUk dxfMmiRXvzLKo4wqEtO1+OsCzpFUKkUe7Nnuw3Tshur3J8XzlNIXZd7/K7eD4vpk Z4BxnNfRamGpzHb7iSkSptlpgMuqTNR/iIihNmVPn+rrtETFyK9zmA9nXCz3Ecif DMCWQWJuB52ZB77R4XV0WRxSe1GtoeKbneU2NOMuqsT+fJ5nbqwnoaZXjSy8BB8l PJirChm2/DDADKjmf/ck+7nZOofAxP6UT/clicQiXuqrtznU5kauMF7q3WCDk3TA PJBBHkDnSNto0kfrWYTb43AYjfOW3yox2GMAvUSqKg7HjUQoqLS8Qu2cfFTWPAX/ bqkxKcz/u8FNIGlyGTby =RzEl -----END PGP SIGNATURE----- --UPT3ojh+0CqEDtpF--