From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38361) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c12GW-0001ND-OX for qemu-devel@nongnu.org; Sun, 30 Oct 2016 22:24:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c12GT-00025q-Ku for qemu-devel@nongnu.org; Sun, 30 Oct 2016 22:24:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36226) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c12GT-00025V-F9 for qemu-devel@nongnu.org; Sun, 30 Oct 2016 22:23:57 -0400 Date: Mon, 31 Oct 2016 10:23:53 +0800 From: Fam Zheng Message-ID: <20161031022353.GG30303@lemon> References: <20161028163339.31096-1-alex.bennee@linaro.org> <20161028163339.31096-4-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20161028163339.31096-4-alex.bennee@linaro.org> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 3/6] tests/docker: add optional libs to travis.docker List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex =?iso-8859-1?Q?Benn=E9e?= Cc: qemu-devel@nongnu.org On Fri, 10/28 17:33, Alex Benn=E9e wrote: > In our .travis.yml we install a bunch of extra libraries which are not > part of the packaged QEMU's builddeps. We include them here to make our > docker container more closely match the state of the system after docke= r > has installed the rest of the build dependencies. >=20 > Signed-off-by: Alex Benn=E9e > --- > tests/docker/dockerfiles/travis.docker | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) >=20 > diff --git a/tests/docker/dockerfiles/travis.docker b/tests/docker/dock= erfiles/travis.docker > index e4983ae..6bef722 100644 > --- a/tests/docker/dockerfiles/travis.docker > +++ b/tests/docker/dockerfiles/travis.docker > @@ -2,5 +2,12 @@ FROM quay.io/travisci/travis-ruby > RUN apt-get update > RUN apt-get -y build-dep qemu > RUN apt-get -y build-dep device-tree-compiler > -RUN apt-get -y install python2.7 dh-autoreconf > +# Additional optional libs not in QEMU's builddep > +RUN apt-get -y install libbrlapi-dev liblttng-ust-dev libcap-ng-dev \ > + libnfs-dev libnss3-dev libpixman-1-dev \ > + libpng12-dev librados-dev libseccomp-dev \ > + libspice-protocol-dev libspice-server-dev \ > + libssh2-1-dev liburcu-dev libusb-1.0-0-dev \ > + libvte-2.90-dev > +RUN apt-get -y install python2.7 dh-autoreconf sparse Any reason to use two apt-get lines? Also, can you put these package names in $PACKAGES and dump 'dpkg -l $PAC= KAGES' to /packages.txt like in ubuntu.docker? That way we can print it in repor= ts by adding SHOW_ENV=3D1 in make invocation. Fam > ENV FEATURES pyyaml > --=20 > 2.10.1 >=20 >=20