From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41461) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c187Q-000231-QZ for qemu-devel@nongnu.org; Mon, 31 Oct 2016 04:39:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c187N-00046e-Lp for qemu-devel@nongnu.org; Mon, 31 Oct 2016 04:39:00 -0400 Date: Mon, 31 Oct 2016 19:37:04 +1100 From: David Gibson Message-ID: <20161031083704.GR18226@umbus.fritz.box> References: <1477825928-10803-1-git-send-email-david@gibson.dropbear.id.au> <1477825928-10803-2-git-send-email-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="QFliEIXSSz7hGqqc" Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [RFC 01/17] ppc: Remove some stub POWER6 models List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: nikunj@linux.vnet.ibm.com, aik@ozlabs.ru, mdroth@linux.vnet.ibm.com, lvivier@redhat.com, qemu-ppc@nongnu.org, qemu-devel@nongnu.org --QFliEIXSSz7hGqqc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 31, 2016 at 08:38:53AM +0100, Thomas Huth wrote: > On 30.10.2016 12:11, David Gibson wrote: > > The CPU model table includes stub (commented out) definitions for > > CPU_POWERPC_POWER6_5 and CPU_POWERPC_POWER6A. These are not real cpu > > models, but represent the POWER6 in some compatiblity modes. If we ever > > do implement POWER6 (unlikely), >=20 > I think we should finally add at least basic support for POWER6. It > always confused me (from a user's point of view) that we have support > for POWER5+ and POWER7, but not for POWER6. I think it's just because at the time POWER6 was current, no-one was working on qemu for Power. It'd be nice to have, but I don't know that it's actually worth anyone's time to make happen. > > we'll implement its compatibility modes in > > a different way (similar to what we do for POWER7 and POWER8). So these > > stub definitions can be removed. > [...] > > diff --git a/target-ppc/cpu-models.c b/target-ppc/cpu-models.c > > index 901cf40..506dee1 100644 > > --- a/target-ppc/cpu-models.c > > +++ b/target-ppc/cpu-models.c > > @@ -1130,10 +1130,6 @@ > > #if defined(TODO) > > POWERPC_DEF("POWER6", CPU_POWERPC_POWER6, P= OWER6, > > "POWER6") > > - POWERPC_DEF("POWER6_5", CPU_POWERPC_POWER6_5, P= OWER5, > > - "POWER6 running in POWER5 mode") > > - POWERPC_DEF("POWER6A", CPU_POWERPC_POWER6A, P= OWER6, > > - "POWER6A") > > #endif > > POWERPC_DEF("POWER7_v2.3", CPU_POWERPC_POWER7_v23, P= OWER7, > > "POWER7 v2.3") > > diff --git a/target-ppc/cpu-models.h b/target-ppc/cpu-models.h > > index 7d9e6a2..aafbbd7 100644 > > --- a/target-ppc/cpu-models.h > > +++ b/target-ppc/cpu-models.h > > @@ -549,8 +549,6 @@ enum { > > CPU_POWERPC_POWER5 =3D 0x003A0203, > > CPU_POWERPC_POWER5P_v21 =3D 0x003B0201, > > CPU_POWERPC_POWER6 =3D 0x003E0000, > > - CPU_POWERPC_POWER6_5 =3D 0x0F000001, /* POWER6 in POWER5= mode */ > > - CPU_POWERPC_POWER6A =3D 0x0F000002, > > CPU_POWERPC_POWER_SERVER_MASK =3D 0xFFFF0000, > > CPU_POWERPC_POWER7_BASE =3D 0x003F0000, > > CPU_POWERPC_POWER7_v23 =3D 0x003F0203, >=20 >=20 > Patch looks good. >=20 > Reviewed-by: Thomas Huth >=20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --QFliEIXSSz7hGqqc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYFwKuAAoJEGw4ysog2bOSI00P/0zIrcl0Rpvvcx4vqId0RIab WjLliKHwtwdA4Vz1XIzVkILG1EBaaHekBvlwm9eVjScSAcdCVvZu44wlNlfiBCKq f91AHu/Apz3+6AOMHx7st2nXbdX9CxvhmqKHmJaxwM6ILFdMjbBn4tyytR1ETLqB O2xXcTW1BD/WWH0DKoKWN0ZvgKRxnuxGX3eR/dobt4ZdIvYVM20Nkj0AzhGmLDE4 Z71gMMavVwiL/gUSddFdOh2JlshSwI5FCsWumxP0+kxVFHnUCpHVA8+EiDDrAv2r zD3+gIE8Ywepth1PC0hU94aBh3m1qyOkJMIwW6UfaBO7NXZK+8sydDjAwvo5i2jf 2AFK3CH/hpgWF1vbVajjtzzdZqOAAzLNEku2BZN3cUlSBI5WIEjAsOP7CaxIdarx N1Lb/MVC1sYNRoy7JyWmemkKmcf4F09T1RaMOqoCxRSjJ4BdJ41QTY1xisXZLuiA hSAf3KlGXDtR/9liAeL2PKAQ7pA62dSETCuykcK1YKQte1FdA6SnIy+2TqjMaXfG M9rK5p6rmlG45Yc8hMQm0bCrKm71KXB4BrvOnuEl5PT0lDCd/7FhcS5P4qBHkpyN ccZMRRHeKFHD89GGmDnP3BJpqQAvPkIaZmApWitOtdlXaiesW+RwQB0NLe6lAalp qytSyHo0o7HyTzFYnmQN =DFtC -----END PGP SIGNATURE----- --QFliEIXSSz7hGqqc--