From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52885) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c18vW-0002b8-8D for qemu-devel@nongnu.org; Mon, 31 Oct 2016 05:30:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c18vS-0004iL-Vu for qemu-devel@nongnu.org; Mon, 31 Oct 2016 05:30:46 -0400 Received: from 8.mo5.mail-out.ovh.net ([178.32.116.78]:46392) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c18vS-0004hS-LB for qemu-devel@nongnu.org; Mon, 31 Oct 2016 05:30:42 -0400 Received: from player774.ha.ovh.net (b7.ovh.net [213.186.33.57]) by mo5.mail-out.ovh.net (Postfix) with ESMTP id 7E2E440DB8 for ; Mon, 31 Oct 2016 10:30:39 +0100 (CET) Date: Mon, 31 Oct 2016 10:30:33 +0100 From: Greg Kurz Message-ID: <20161031103033.71cac9cc@bahia> In-Reply-To: <8df5227c-0475-59cc-a5fe-a9dbc1a90c4e@cn.fujitsu.com> References: <1477448651-4474-1-git-send-email-jasowang@redhat.com> <1477448651-4474-10-git-send-email-jasowang@redhat.com> <20161030131323.7dc17bcd@bahia> <3baa4c61-f984-ec03-b8c2-0d2f367f3594@cn.fujitsu.com> <24dd6bd4-69fd-1a21-c8bd-207b1f4b1ee7@redhat.com> <8df5227c-0475-59cc-a5fe-a9dbc1a90c4e@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL 9/9] colo-proxy: fix memory leak List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Zhang Chen Cc: Jason Wang , qemu-devel@nongnu.org, peter.maydell@linaro.org, Stefan Hajnoczi On Mon, 31 Oct 2016 16:05:00 +0800 Zhang Chen wrote: > On 10/31/2016 03:40 PM, Jason Wang wrote: > > > > > > On 2016=E5=B9=B410=E6=9C=8831=E6=97=A5 14:37, Zhang Chen wrote: =20 > >> > >> > >> On 10/30/2016 08:13 PM, Greg Kurz wrote: =20 > >>> On Wed, 26 Oct 2016 10:24:11 +0800 > >>> Jason Wang wrote: > >>> =20 > >>>> From: Zhang Chen > >>>> > >>>> Fix memory leak in colo-compare.c and filter-rewriter.c > >>>> Report by Coverity and add some comments. > >>>> > >>>> Signed-off-by: Zhang Chen > >>>> Reviewed-by: zhanghailiang > >>>> Signed-off-by: Jason Wang > >>>> --- =20 > >>> Hi, > >>> > >>> This commit breaks --enable-trace-backends=3Dust builds in travis (#1= 7): > >>> > >>> In file included from ./trace/generated-tracers.h:5966:0, > >>> from /home/travis/build/gkurz/qemu/include/trace.h:= 4, > >>> from qapi/qapi-visit-core.c:22: > >>> ./trace/generated-ust-provider.h:18625:3: error: unknown type name=20 > >>> =E2=80=98_TP_EXPROTOint=E2=80=99 > >>> In file included from=20 > >>> /home/travis/build/gkurz/qemu/include/trace.h:4:0, > >>> from qapi/qapi-visit-core.c:22: > >>> ./trace/generated-tracers.h: In function =E2=80=98trace_colo_compare_= pkt_info=E2=80=99: > >>> ./trace/generated-tracers.h:19249:432: error: expected string=20 > >>> literal before =E2=80=98_SDT_ASM_OPERANDS_ssize=E2=80=99 > >>> ./trace/generated-tracers.h:19249:432: error: implicit declaration=20 > >>> of function =E2=80=98__tracepoint_cb_qemu___colo_compare_pkt_info=E2= =80=99=20 > >>> [-Werror=3Dimplicit-function-declaration] > >>> ./trace/generated-tracers.h:19249:432: error: nested extern=20 > >>> declaration of =E2=80=98__tracepoint_cb_qemu___colo_compare_pkt_info= =E2=80=99=20 > >>> [-Werror=3Dnested-externs] > >>> cc1: all warnings being treated as errors > >>> make: *** [qapi/qapi-visit-core.o] Error 1 > >>> make: *** Waiting for unfinished jobs.... > >>> > >>> https://travis-ci.org/gkurz/qemu/jobs/171641119 =20 > >> > >> I got your point and test it, same problem in here. > >> I found that when trace args >10 it not work(this trace have 11 args), > >> else it works well like that: > >> > >> colo_compare_pkt_info(const char *src, const char *dst, uint32_t=20 > >> pseq, uint32_t pack, uint32_t sseq, uint32_t sack, int res, uint32_t=20 > >> pflag, uint32_t sflag, const char *src1) "src/dst: %s/%s p:=20 > >> seq/ack=3D%u/%u s: seq/ack=3D%u/%u res=3D%d flags=3D%x/%x %s\n" > >> > >> So I think this bug could be related to trace system, but I review=20 > >> trace codes nothing be found about this. > >> CC: stefan > >> > >> Thanks =20 > > > > We met similar issue in the past which looks like a limitation of the=20 > > backend. > > > > Btw, Alex Bennee has posted a workaround for this, could you please=20 > > review or ack on that patch? =20 >=20 > Can you give me a patch name ? and about this patch, should I send a=20 > patch split this trace_event > to two trace_event first ? >=20 This is what Alex's patch does :) net: split colo_compare_pkt_info into two trace events <20161028132559.8324-1-alex.bennee@linaro.org> > Thanks > Zhang Chen >=20 Cheers. -- Greg