From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60804) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c1BI0-0001pa-4J for qemu-devel@nongnu.org; Mon, 31 Oct 2016 08:02:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c1BHw-0008JZ-5y for qemu-devel@nongnu.org; Mon, 31 Oct 2016 08:02:08 -0400 Received: from hera.aquilenet.fr ([141.255.128.1]:46956) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c1BHw-0008J7-1R for qemu-devel@nongnu.org; Mon, 31 Oct 2016 08:02:04 -0400 Date: Mon, 31 Oct 2016 13:01:59 +0100 From: Samuel Thibault Message-ID: <20161031120159.GH3671@var.home> References: <1477656698-13569-1-git-send-email-kraxel@redhat.com> <1477656698-13569-7-git-send-email-kraxel@redhat.com> <20161031124530.2aad6ed6.cornelia.huck@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20161031124530.2aad6ed6.cornelia.huck@de.ibm.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL 6/6] curses: Use cursesw instead of curses List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck Cc: Gerd Hoffmann , qemu-devel@nongnu.org Cornelia Huck, on Mon 31 Oct 2016 12:45:30 +0100, wrote: > > From: Samuel Thibault > >=20 > > Use ncursesw package instead of curses on non-mingw, and check a few > > functions. > > Also take cflags from pkg-config, since cursesw headers may be in a > > separate, non-default directory. > >=20 > > Signed-off-by: Samuel Thibault > > Message-id: 20161015195308.20473-3-samuel.thibault@ens-lyon.org > > Signed-off-by: Gerd Hoffmann > > --- > > configure | 29 ++++++++++++++++++++--------- > > 1 file changed, 20 insertions(+), 9 deletions(-) >=20 > This seems to break configure on one of the systems I use (which may or > may not have a broken setup). SLES12SP1 (s390x) without curses in the > output of pkg-config --list-all, but headers seem to be present (? -- > I'm not the admin). Other systems (Fedora and Ubuntu) are fine. > config-temp/qemu-conf.c:9:3: warning: implicit declaration of function = =E2=80=98addwstr=E2=80=99 [-Wimplicit-function-declaration] Bleh. Could you try to replace #include with #include in ui/curses.c, to see whether that fixes the missing declaration on that system? We could be trying both headers to look for the wide functions and include the one which works. Samuel