From: Samuel Thibault <samuel.thibault@gnu.org>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PULL 6/6] curses: Use cursesw instead of curses
Date: Mon, 31 Oct 2016 13:39:30 +0100 [thread overview]
Message-ID: <20161031123930.GM3671@var.home> (raw)
In-Reply-To: <20161031130806.272eef44.cornelia.huck@de.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 253 bytes --]
Cornelia Huck, on Mon 31 Oct 2016 13:08:06 +0100, wrote:
> You mean in configure, right? Including cursesw.h in the test program
> gets configure going again.
Could you try the attached patch which fixes both configure and
ui/curses.c?
Thanks,
Samuel
[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 1260 bytes --]
diff --git a/configure b/configure
index f83cdf8..bae01f0 100755
--- a/configure
+++ b/configure
@@ -2920,13 +2920,17 @@ if test "$curses" != "no" ; then
curses_inc_list="$($pkg_config --cflags ncurses 2>/dev/null):"
curses_lib_list="$($pkg_config --libs ncurses 2>/dev/null):-lpdcurses"
else
- curses_inc_list="$($pkg_config --cflags ncursesw 2>/dev/null):"
+ curses_inc_list="$($pkg_config --cflags ncursesw 2>/dev/null):-DCONFIG_CURSESW_H:"
curses_lib_list="$($pkg_config --libs ncursesw 2>/dev/null):-lncursesw:-lcursesw"
fi
curses_found=no
cat > $TMPC << EOF
#include <locale.h>
+#ifdef CONFIG_CURSESW_H
+#include <cursesw.h>
+#else
#include <curses.h>
+#endif
#include <wchar.h>
int main(void) {
const char *s = curses_version();
@@ -2949,6 +2953,9 @@ EOF
break
fi
done
+ if test "$curses_found" = yes ; then
+ break
+ fi
done
unset IFS
if test "$curses_found" = "yes" ; then
diff --git a/ui/curses.c b/ui/curses.c
index 2e132a7..cb61073 100644
--- a/ui/curses.c
+++ b/ui/curses.c
@@ -22,7 +22,11 @@
* THE SOFTWARE.
*/
#include "qemu/osdep.h"
+#ifdef CONFIG_CURSESW_H
+#include <cursesw.h>
+#else
#include <curses.h>
+#endif
#ifndef _WIN32
#include <sys/ioctl.h>
next prev parent reply other threads:[~2016-10-31 12:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-28 12:11 [Qemu-devel] [PULL 0/6] ui patch queue Gerd Hoffmann
2016-10-28 12:11 ` [Qemu-devel] [PULL 1/6] Add dots keypresses support to the baum braille device Gerd Hoffmann
2016-10-28 12:11 ` [Qemu-devel] [PULL 2/6] Defer BrlAPI tty acquisition to when guest starts using device Gerd Hoffmann
2016-10-28 12:11 ` [Qemu-devel] [PULL 3/6] gtk: fix compilation warning with gtk 3.22.2 Gerd Hoffmann
2016-10-28 12:11 ` [Qemu-devel] [PULL 4/6] ui/gtk: Fix non-working DELETE key Gerd Hoffmann
2016-10-28 12:11 ` [Qemu-devel] [PULL 5/6] curses: fix left/right arrow translation Gerd Hoffmann
2016-10-28 12:11 ` [Qemu-devel] [PULL 6/6] curses: Use cursesw instead of curses Gerd Hoffmann
2016-10-31 11:45 ` Cornelia Huck
2016-10-31 12:01 ` Samuel Thibault
2016-10-31 12:05 ` Samuel Thibault
2016-10-31 12:08 ` Cornelia Huck
2016-10-31 12:16 ` Samuel Thibault
2016-10-31 12:39 ` Samuel Thibault [this message]
2016-10-31 12:48 ` Cornelia Huck
2016-10-31 14:03 ` Samuel Thibault
2016-10-31 13:08 ` Cornelia Huck
2016-10-31 15:39 ` Samuel Thibault
2016-11-02 9:09 ` Cornelia Huck
2016-10-28 17:55 ` [Qemu-devel] [PULL 0/6] ui patch queue Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161031123930.GM3671@var.home \
--to=samuel.thibault@gnu.org \
--cc=cornelia.huck@de.ibm.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).