From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55067) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c1B2D-0002oF-SU for qemu-devel@nongnu.org; Mon, 31 Oct 2016 07:45:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c1B28-0002TP-RF for qemu-devel@nongnu.org; Mon, 31 Oct 2016 07:45:49 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:38556 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c1B28-0002TH-MO for qemu-devel@nongnu.org; Mon, 31 Oct 2016 07:45:44 -0400 Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id u9VBhdNi086685 for ; Mon, 31 Oct 2016 07:45:44 -0400 Received: from e06smtp06.uk.ibm.com (e06smtp06.uk.ibm.com [195.75.94.102]) by mx0b-001b2d01.pphosted.com with ESMTP id 26dsvcv6s9-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Mon, 31 Oct 2016 07:45:43 -0400 Received: from localhost by e06smtp06.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 31 Oct 2016 11:45:42 -0000 Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 03E2F1B0804B for ; Mon, 31 Oct 2016 11:47:48 +0000 (GMT) Received: from d06av09.portsmouth.uk.ibm.com (d06av09.portsmouth.uk.ibm.com [9.149.37.250]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u9VBjdOZ15008104 for ; Mon, 31 Oct 2016 11:45:39 GMT Received: from d06av09.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av09.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u9VBjcBt027607 for ; Mon, 31 Oct 2016 05:45:38 -0600 Date: Mon, 31 Oct 2016 12:45:30 +0100 From: Cornelia Huck In-Reply-To: <1477656698-13569-7-git-send-email-kraxel@redhat.com> References: <1477656698-13569-1-git-send-email-kraxel@redhat.com> <1477656698-13569-7-git-send-email-kraxel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Message-Id: <20161031124530.2aad6ed6.cornelia.huck@de.ibm.com> Subject: Re: [Qemu-devel] [PULL 6/6] curses: Use cursesw instead of curses List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann , Samuel Thibault Cc: qemu-devel@nongnu.org On Fri, 28 Oct 2016 14:11:38 +0200 Gerd Hoffmann wrote: > From: Samuel Thibault >=20 > Use ncursesw package instead of curses on non-mingw, and check a few > functions. > Also take cflags from pkg-config, since cursesw headers may be in a > separate, non-default directory. >=20 > Signed-off-by: Samuel Thibault > Message-id: 20161015195308.20473-3-samuel.thibault@ens-lyon.org > Signed-off-by: Gerd Hoffmann > --- > configure | 29 ++++++++++++++++++++--------- > 1 file changed, 20 insertions(+), 9 deletions(-) This seems to break configure on one of the systems I use (which may or may not have a broken setup). SLES12SP1 (s390x) without curses in the output of pkg-config --list-all, but headers seem to be present (? -- I'm not the admin). Other systems (Fedora and Ubuntu) are fine. Before this commit, configure detected curses=3Dyes and all seemed well. Now, configure barfs about -Werror. Some snippets from config.log: # QEMU configure log Mon Oct 31 12:35:26 CET 2016 # Configured with: '/home/cohuck/git/qemu/build/../configure' '--target-lis= t=3Ds39 0x-softmmu s390x-linux-user' '--enable-kvm' '--enable-vhost-net' '--enable-= linux -aio' cc -m64 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=3D64 -D_LARGEFILE_SOURCE -Wstrict= -protot ypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -= fno-s trict-aliasing -fno-common -fwrapv -Wendif-labels -Wmissing-include-dirs -W= empty -body -Wnested-externs -Wformat-security -Wformat-y2k -Winit-self -Wignored= -qual ifiers -Wold-style-declaration -Wold-style-definition -Wtype-limits -fstack= -prot ector-all -I/usr/include/libpng16 -o config-temp/qemu-conf.exe config-temp/= qemu- conf.c -m64 -g config-temp/qemu-conf.c: In function =E2=80=98main=E2=80=99: config-temp/qemu-conf.c:9:3: warning: implicit declaration of function =E2= =80=98addwstr=E2=80=99 [-Wimplicit-function-declaration] addwstr(L"wide chars\n"); ^ config-temp/qemu-conf.c:9:3: warning: nested extern declaration of =E2=80= =98addwstr=E2=80=99 [-Wnested-externs] config-temp/qemu-conf.c:10:3: warning: implicit declaration of function =E2= =80=98addnwstr=E2=80=99 [-Wimplicit-function-declaration] addnwstr(&wch, 1); ^ config-temp/qemu-conf.c:10:3: warning: nested extern declaration of =E2=80= =98addnwstr=E2=80=99 [-Wnested-externs] /tmp/ccgsfoYo.o: In function `main': /home/cohuck/git/qemu/build/config-temp/qemu-conf.c:5: undefined reference = to `curses_version' /home/cohuck/git/qemu/build/config-temp/qemu-conf.c:8: undefined reference = to `resize_term' /home/cohuck/git/qemu/build/config-temp/qemu-conf.c:9: undefined reference = to `addwstr' /home/cohuck/git/qemu/build/config-temp/qemu-conf.c:10: undefined reference= to `addnwstr' collect2: error: ld returned 1 exit status cc -m64 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=3D64 -D_LARGEFILE_SOURCE -Wstrict= -prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-proto= types -fno-strict-aliasing -fno-common -fwrapv -Wendif-labels -Wmissing-inc= lude-dirs -Wempty-body -Wnested-externs -Wformat-security -Wformat-y2k -Win= it-self -Wignored-qualifiers -Wold-style-declaration -Wold-style-definition= -Wtype-limits -fstack-protector-all -I/usr/include/libpng16 -o config-temp= /qemu-conf.exe config-temp/qemu-conf.c -m64 -g -lncursesw config-temp/qemu-conf.c: In function =E2=80=98main=E2=80=99: config-temp/qemu-conf.c:9:3: warning: implicit declaration of function =E2= =80=98addwstr=E2=80=99 [-Wimplicit-function-declaration] addwstr(L"wide chars\n"); ^ config-temp/qemu-conf.c:9:3: warning: nested extern declaration of =E2=80= =98addwstr=E2=80=99 [-Wnested-externs] config-temp/qemu-conf.c:10:3: warning: implicit declaration of function =E2= =80=98addnwstr=E2=80=99 [-Wimplicit-function-declaration] addnwstr(&wch, 1); ^ config-temp/qemu-conf.c:10:3: warning: nested extern declaration of =E2=80= =98addnwstr=E2=80=99 [-Wnested-externs] /tmp/ccgsfoYo.o: In function `main': /home/cohuck/git/qemu/build/config-temp/qemu-conf.c:5: undefined reference = to `curses_version' /home/cohuck/git/qemu/build/config-temp/qemu-conf.c:8: undefined reference = to `resize_term' /home/cohuck/git/qemu/build/config-temp/qemu-conf.c:9: undefined reference = to `addwstr' /home/cohuck/git/qemu/build/config-temp/qemu-conf.c:10: undefined reference= to `addnwstr' collect2: error: ld returned 1 exit status cc -m64 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=3D64 -D_LARGEFILE_SOURCE -Wstrict= -prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-proto= types -fno-strict-aliasing -fno-common -fwrapv -Wendif-labels -Wmissing-inc= lude-dirs -Wempty-body -Wnested-externs -Wformat-security -Wformat-y2k -Win= it-self -Wignored-qualifiers -Wold-style-declaration -Wold-style-definition= -Wtype-limits -fstack-protector-all -I/usr/include/libpng16 -o config-temp= /qemu-conf.exe config-temp/qemu-conf.c -m64 -g -lncursesw config-temp/qemu-conf.c: In function =E2=80=98main=E2=80=99: config-temp/qemu-conf.c:9:3: warning: implicit declaration of function =E2= =80=98addwstr=E2=80=99 [-Wimplicit-function-declaration] addwstr(L"wide chars\n"); ^ config-temp/qemu-conf.c:9:3: warning: nested extern declaration of =E2=80= =98addwstr=E2=80=99 [-Wnested-externs] config-temp/qemu-conf.c:10:3: warning: implicit declaration of function =E2= =80=98addnwstr=E2=80=99 [-Wimplicit-function-declaration] addnwstr(&wch, 1); ^ config-temp/qemu-conf.c:10:3: warning: nested extern declaration of =E2=80= =98addnwstr=E2=80=99 [-Wnested-externs] cc -Werror -m64 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=3D64 -D_LARGEFILE_SOURCE = -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissi= ng-prototypes -fno-strict-aliasing -fno-common -fwrapv -Wendif-labels -Wmis= sing-include-dirs -Wempty-body -Wnested-externs -Wformat-security -Wformat-= y2k -Winit-self -Wignored-qualifiers -Wold-style-declaration -Wold-style-de= finition -Wtype-limits -fstack-protector-all -I/usr/include/libpng16 -o con= fig-temp/qemu-conf.exe config-temp/qemu-conf.c -m64 -g -lncursesw config-temp/qemu-conf.c: In function =E2=80=98main=E2=80=99: config-temp/qemu-conf.c:9:3: error: implicit declaration of function =E2=80= =98addwstr=E2=80=99 [-Werror=3Dimplicit-function-declaration] addwstr(L"wide chars\n"); ^ config-temp/qemu-conf.c:9:3: error: nested extern declaration of =E2=80=98a= ddwstr=E2=80=99 [-Werror=3Dnested-externs] config-temp/qemu-conf.c:10:3: error: implicit declaration of function =E2= =80=98addnwstr=E2=80=99 [-Werror=3Dimplicit-function-declaration] addnwstr(&wch, 1); ^ config-temp/qemu-conf.c:10:3: error: nested extern declaration of =E2=80=98= addnwstr=E2=80=99 [-Werror=3Dnested-externs] cc1: all warnings being treated as errors As said, I'm not sure whether this system has a sane setup, and I'm just a user there. Just noticed this new breakage (which goes away with --disable-curses).