From: Kevin Wolf <kwolf@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: qemu-block@nongnu.org, hpoussin@reactos.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] atapi: classify read_cd as conditionally returning data
Date: Mon, 31 Oct 2016 15:06:48 +0100 [thread overview]
Message-ID: <20161031140648.GD5522@noname.redhat.com> (raw)
In-Reply-To: <1477693948-14419-1-git-send-email-jsnow@redhat.com>
Am 29.10.2016 um 00:32 hat John Snow geschrieben:
> For the purposes of byte_count_limit verification, add a new flag that
> identifies read_cd as sometimes returning data, then check the BCL in
> its command handler after we know that it will indeed return data.
>
> Reported-by: Hervé Poussineau <hpoussin@reactos.org>
> Signed-off-by: John Snow <jsnow@redhat.com>
Wouldn't it be useful to actually add the new flag to cmd_read_cd then?
While at it, I would also split the patch into one for adding the flag
and one for updating cmd_read_cd.
Also, would it be hard to add a qtest case for this?
Kevin
next prev parent reply other threads:[~2016-10-31 14:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-28 22:32 [Qemu-devel] [PATCH] atapi: classify read_cd as conditionally returning data John Snow
2016-10-30 17:49 ` Hervé Poussineau
2016-10-31 15:10 ` John Snow
2016-10-31 2:57 ` no-reply
2016-10-31 14:06 ` Kevin Wolf [this message]
2016-10-31 15:12 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161031140648.GD5522@noname.redhat.com \
--to=kwolf@redhat.com \
--cc=hpoussin@reactos.org \
--cc=jsnow@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).