From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60165) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c1DEx-0004E2-AN for qemu-devel@nongnu.org; Mon, 31 Oct 2016 10:07:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c1DEr-0000pQ-RB for qemu-devel@nongnu.org; Mon, 31 Oct 2016 10:07:07 -0400 Date: Mon, 31 Oct 2016 15:06:48 +0100 From: Kevin Wolf Message-ID: <20161031140648.GD5522@noname.redhat.com> References: <1477693948-14419-1-git-send-email-jsnow@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <1477693948-14419-1-git-send-email-jsnow@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] atapi: classify read_cd as conditionally returning data List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow Cc: qemu-block@nongnu.org, hpoussin@reactos.org, qemu-devel@nongnu.org Am 29.10.2016 um 00:32 hat John Snow geschrieben: > For the purposes of byte_count_limit verification, add a new flag that > identifies read_cd as sometimes returning data, then check the BCL in > its command handler after we know that it will indeed return data. >=20 > Reported-by: Herv=E9 Poussineau > Signed-off-by: John Snow Wouldn't it be useful to actually add the new flag to cmd_read_cd then? While at it, I would also split the patch into one for adding the flag and one for updating cmd_read_cd. Also, would it be hard to add a qtest case for this? Kevin