From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37494) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c1Dfz-0002nr-B7 for qemu-devel@nongnu.org; Mon, 31 Oct 2016 10:35:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c1Dfu-0002lX-AD for qemu-devel@nongnu.org; Mon, 31 Oct 2016 10:35:03 -0400 Date: Mon, 31 Oct 2016 14:34:48 +0000 From: "Daniel P. Berrange" Message-ID: <20161031143448.GE2668@redhat.com> Reply-To: "Daniel P. Berrange" References: <1474306544-24708-1-git-send-email-berrange@redhat.com> <1474306544-24708-2-git-send-email-berrange@redhat.com> <5a389739-00eb-48a2-188b-31030337e3eb@redhat.com> <20160920093635.GA25490@redhat.com> <6a34a3f9-7ac4-ab53-1921-40a8e21a6a88@redhat.com> <20160920141528.GO25490@redhat.com> <20160920143959.GR25490@redhat.com> <20161031142823.GG5522@noname.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20161031142823.GG5522@noname.redhat.com> Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 1/6] iotests: throw away test timings if args change List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Eric Blake , qemu-devel@nongnu.org, qemu-block@nongnu.org, Max Reitz On Mon, Oct 31, 2016 at 03:28:23PM +0100, Kevin Wolf wrote: > Am 20.09.2016 um 16:39 hat Daniel P. Berrange geschrieben: > > On Tue, Sep 20, 2016 at 09:38:33AM -0500, Eric Blake wrote: > > > On 09/20/2016 09:15 AM, Daniel P. Berrange wrote: > > > >>> I guess we could keep things simple by not inventing a new format, > > > >>> but instead of using 'check.time', use 'check.time.$FORMAT-$PROTOCOL' > > > >>> eg 'check.time.qcow2-file' > > > >> > > > >> Seems more palatable. Lots of files rather than lots of lines in a > > > >> single file; searching is now fast (if you can come up with the right > > > >> file name, the OS does the searching for you rather than us having to > > > >> figure out which (if any) portion of a large file applies). We may > > > >> still want a command for easily cleaning everything, and if we do switch > > > >> to new file names, we'll still want to clean up the old files. > > > > > > > > Isn't that command called 'git clean -f' - if we remove 'check.time' > > > > from the gitignore file, it'll be deleted by a git clean, without > > > > needing to ass the -i flag. I don't think we really need to reinvent > > > > a special way to clean just these timing files, particularly since > > > > they are not large. > > > > > > I'd still rather have the gitignore file ignore anything that we don't > > > want to check into the tree (I'm a big fan of 'git add -a .', and hate > > > it when non-ignored generated files interfere with that; yes I know I > > > can munge .git/info/exclude locally, but it feels cleaner when generated > > > files are ignored at the project level). > > > > > > But yes, relying on git to do the cleanup is fine from my point of view. > > > > NB, I'd still suggest ignoring check.time-$FORMAT-BACKEND files since > > those are current. I was just refering to removal of the legacy check.time > > file so next git cleanup kills the obsolete file > > Was there a v2 of this series that I missed or was it just forgotten? I never got around to sending a v2 Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|