From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53997) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c1EgQ-0005Lw-DQ for qemu-devel@nongnu.org; Mon, 31 Oct 2016 11:39:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c1EgP-0005As-H5 for qemu-devel@nongnu.org; Mon, 31 Oct 2016 11:39:34 -0400 Received: from hera.aquilenet.fr ([2a01:474::1]:44649) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c1EgP-0005AC-AH for qemu-devel@nongnu.org; Mon, 31 Oct 2016 11:39:33 -0400 Date: Mon, 31 Oct 2016 16:39:29 +0100 From: Samuel Thibault Message-ID: <20161031153929.GK11941@var.home> References: <1477656698-13569-1-git-send-email-kraxel@redhat.com> <1477656698-13569-7-git-send-email-kraxel@redhat.com> <20161031124530.2aad6ed6.cornelia.huck@de.ibm.com> <20161031120159.GH3671@var.home> <20161031130806.272eef44.cornelia.huck@de.ibm.com> <20161031123930.GM3671@var.home> <20161031134801.49697f92.cornelia.huck@de.ibm.com> <20161031140333.GA4298@var.eduroam.u-bordeaux.fr> <20161031140848.68bdc709.cornelia.huck@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20161031140848.68bdc709.cornelia.huck@de.ibm.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL 6/6] curses: Use cursesw instead of curses List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck Cc: Gerd Hoffmann , qemu-devel@nongnu.org Cornelia Huck, on Mon 31 Oct 2016 14:08:48 +0100, wrote: > On Mon, 31 Oct 2016 15:03:33 +0100 > Samuel Thibault wrote: >=20 > > Cornelia Huck, on Mon 31 Oct 2016 13:48:01 +0100, wrote: > > > On Mon, 31 Oct 2016 13:39:30 +0100 > > > Samuel Thibault wrote: > > >=20 > > > > Cornelia Huck, on Mon 31 Oct 2016 13:08:06 +0100, wrote: > > > > > You mean in configure, right? Including cursesw.h in the test p= rogram > > > > > gets configure going again. > > > >=20 > > > > Could you try the attached patch which fixes both configure and > > > > ui/curses.c? > > >=20 > > > Sadly, this does not fix it for me. I get the same errors in the > > > configure test build as before. > >=20 > > Could you post the config.log so we get a better view at what is goin= g > > wrong? >=20 > Attached. > cc -m64 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=3D64 -D_LARGEFILE_SOURCE -Wst= rict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing= -prototypes -fno-strict-aliasing -fno-common -fwrapv -Wendif-labels -Wmis= sing-include-dirs -Wempty-body -Wnested-externs -Wformat-security -Wforma= t-y2k -Winit-self -Wignored-qualifiers -Wold-style-declaration -Wold-styl= e-definition -Wtype-limits -fstack-protector-all -I/usr/include/libpng16 = -o config-temp/qemu-conf.exe config-temp/qemu-conf.c -m64 -g > config-temp/qemu-conf.c: In function =E2=80=98main=E2=80=99: > config-temp/qemu-conf.c:13:3: warning: implicit declaration of function= =E2=80=98addwstr=E2=80=99 [-Wimplicit-function-declaration] ... > cc -m64 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=3D64 -D_LARGEFILE_SOURCE -Wst= rict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing= -prototypes -fno-strict-aliasing -fno-common -fwrapv -Wendif-labels -Wmis= sing-include-dirs -Wempty-body -Wnested-externs -Wformat-security -Wforma= t-y2k -Winit-self -Wignored-qualifiers -Wold-style-declaration -Wold-styl= e-definition -Wtype-limits -fstack-protector-all -I/usr/include/libpng16 = -o config-temp/qemu-conf.exe config-temp/qemu-conf.c -m64 -g -lncursesw > config-temp/qemu-conf.c: In function =E2=80=98main=E2=80=99: > config-temp/qemu-conf.c:13:3: warning: implicit declaration of function= =E2=80=98addwstr=E2=80=99 [-Wimplicit-function-declaration] ... > cc -Werror -m64 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=3D64 -D_LARGEFILE_SOU= RCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -= Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -Wendif-labe= ls -Wmissing-include-dirs -Wempty-body -Wnested-externs -Wformat-security= -Wformat-y2k -Winit-self -Wignored-qualifiers -Wold-style-declaration -W= old-style-definition -Wtype-limits -fstack-protector-all -I/usr/include/l= ibpng16 -o config-temp/qemu-conf.exe config-temp/qemu-conf.c -m64 -g -lnc= ursesw > config-temp/qemu-conf.c: In function =E2=80=98main=E2=80=99: > config-temp/qemu-conf.c:13:3: error: implicit declaration of function =E2= =80=98addwstr=E2=80=99 [-Werror=3Dimplicit-function-declaration] > addwstr(L"wide chars\n"); > ^ > config-temp/qemu-conf.c:13:3: error: nested extern declaration of =E2=80= =98addwstr=E2=80=99 [-Werror=3Dnested-externs] > config-temp/qemu-conf.c:14:3: error: implicit declaration of function =E2= =80=98addnwstr=E2=80=99 [-Werror=3Dimplicit-function-declaration] > addnwstr(&wch, 1); > ^ > config-temp/qemu-conf.c:14:3: error: nested extern declaration of =E2=80= =98addnwstr=E2=80=99 [-Werror=3Dnested-externs] > cc1: all warnings being treated as errors These are expected But doesn't configure also try with -DCONFIG_CURSESW_H? Does it really stop here? Samuel