From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57414)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1c1EpW-0005ZP-VC
	for qemu-devel@nongnu.org; Mon, 31 Oct 2016 11:48:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1c1EpW-0007Zu-8V
	for qemu-devel@nongnu.org; Mon, 31 Oct 2016 11:48:59 -0400
Date: Mon, 31 Oct 2016 16:48:45 +0100
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20161031154845.GC12558@noname.redhat.com>
References: <1477926350-15869-1-git-send-email-ashijeetacharya@gmail.com>
	<1477926350-15869-2-git-send-email-ashijeetacharya@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1477926350-15869-2-git-send-email-ashijeetacharya@gmail.com>
Subject: Re: [Qemu-devel] [PATCH v6 1/2] block/nfs: Introduce runtime_opts
 in NFS
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Ashijeet Acharya <ashijeetacharya@gmail.com>
Cc: eblake@redhat.com, pl@kamp.de, jcody@redhat.com, mreitz@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org

Am 31.10.2016 um 16:05 hat Ashijeet Acharya geschrieben:
> Make NFS block driver use various fine grained runtime_opts.
> Set .bdrv_parse_filename() to nfs_parse_filename() and introduce two
> new functions nfs_parse_filename() and nfs_parse_uri() to help parsing
> the URI.
> Add a new option "server" which then accepts a new struct NFSServer.
> 
> Signed-off-by: Ashijeet Acharya <ashijeetacharya@gmail.com>

> @@ -413,14 +612,13 @@ static int64_t nfs_client_open(NFSClient *client, const char *filename,
>      ret = DIV_ROUND_UP(st.st_size, BDRV_SECTOR_SIZE);
>      client->st_blocks = st.st_blocks;
>      client->has_zero_init = S_ISREG(st.st_mode);
> +    sprintf(client->path, "%s%s", client->path, file);

This doesn't work. I'm replacing the line with *strp = '/';

Kevin