From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43378)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1c1KUu-0002kR-Qh
	for qemu-devel@nongnu.org; Mon, 31 Oct 2016 17:52:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1c1KUr-0006Lm-NZ
	for qemu-devel@nongnu.org; Mon, 31 Oct 2016 17:52:04 -0400
Received: from mx1.redhat.com ([209.132.183.28]:35256)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <jcody@redhat.com>) id 1c1KUr-0006LT-IB
	for qemu-devel@nongnu.org; Mon, 31 Oct 2016 17:52:01 -0400
Date: Mon, 31 Oct 2016 17:51:59 -0400
From: Jeff Cody <jcody@redhat.com>
Message-ID: <20161031215159.GF17785@localhost.localdomain>
References: <05a758e9-027f-d1d1-82f9-cf78627ad63b@ilande.co.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <05a758e9-027f-d1d1-82f9-cf78627ad63b@ilande.co.uk>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] git master build failure (migration/colo.c)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Cc: qemu-devel <qemu-devel@nongnu.org>

On Mon, Oct 31, 2016 at 08:08:46PM +0000, Mark Cave-Ayland wrote:
> I've just done a git pull and get the following build error here:
>=20
> cc -I/home/build/src/qemu/git/qemu/tcg
> -I/home/build/src/qemu/git/qemu/tcg/i386
> -I/home/build/src/qemu/git/qemu/linux-headers
> -I/home/build/src/qemu/git/qemu/linux-headers -I.
> -I/home/build/src/qemu/git/qemu -I/home/build/src/qemu/git/qemu/include
> -Imigration -Imigration -I/usr/include/pixman-1
> -I/home/build/src/qemu/git/qemu/dtc/libfdt -Werror -pthread
> -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include
> -m64 -mcx16 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=3D64 -D_LARGEFILE_SOURCE
> -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings
> -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv
> -Wendif-labels -Wmissing-include-dirs -Wempty-body -Wnested-externs
> -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers
> -Wold-style-declaration -Wold-style-definition -Wtype-limits
> -fstack-protector-all -I/usr/include/p11-kit-1
> -I/usr/include/libpng12   -I/home/build/src/qemu/git/qemu/tests -MMD -M=
P
> -MT migration/colo-failover.o -MF migration/colo-failover.d -O2
> -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3D2 -g   -c -o
> migration/colo-failover.o migration/colo-failover.c
> migration/colo.c: In function =E2=80=98colo_process_incoming_thread=E2=80=
=99:
> migration/colo.c:448:9: error: =E2=80=98request=E2=80=99 may be used un=
initialized in
> this function [-Werror=3Dmaybe-uninitialized]
> cc1: all warnings being treated as errors
> make: *** [migration/colo.o] Error 1
> make: *** Waiting for unfinished jobs....
>=20
> Does anyone else see this at all?
>=20

I'm not seeing it for later gcc versions (6.2.1), but I was able to
reproduce on earlier ones (4.4.7, for instance).  I sent a patch out for
this.


Thanks,
Jeff