From: "Daniel P. Berrange" <berrange@redhat.com>
To: Ashish Mittal <ashmit602@gmail.com>
Cc: qemu-devel@nongnu.org, pbonzini@redhat.com, kwolf@redhat.com,
armbru@redhat.com, jcody@redhat.com, famz@redhat.com,
ashish.mittal@veritas.com, stefanha@gmail.com,
Rakesh.Ranjan@veritas.com, Buddhi.Madhav@veritas.com,
Ketan.Nilangekar@veritas.com, Abhijit.Dey@veritas.com,
Venkatesha.Mg@veritas.com
Subject: Re: [Qemu-devel] [PATCH v5] block/vxhs.c Add support for a new block device type called "vxhs"
Date: Tue, 1 Nov 2016 09:07:41 +0000 [thread overview]
Message-ID: <20161101090741.GA11765@redhat.com> (raw)
In-Reply-To: <1477982098-15462-1-git-send-email-ashish.mittal@veritas.com>
On Mon, Oct 31, 2016 at 11:34:58PM -0700, Ashish Mittal wrote:
> Source code for the qnio library that this code loads can be downloaded
> from:
> https://github.com/MittalAshish/libqnio.git
Your patch is unable to compile against this, because the qnio_api.h
header is using a "struct iovec" type in its APIs, but not including
any header to define that type. This causes configure to fail
cc -Werror -DHAS_LIBSSH2_SFTP_FSYNC -pthread -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -D_GNU_SOURCE -fPIE -DPIE -m64 -mcx16 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -I/home/berrange/src/external/libqnio/src -Wendif-labels -Wno-shift-negative-value -Wmissing-include-dirs -Wempty-body -Wnested-externs -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers -Wold-style-declaration -Wold-style-definition -Wtype-limits -fstack-protector-strong -I/usr/include/p11-kit-1 -I/usr/include/libpng16 -I/usr/include/cacard -I/usr/include/nss3 -I/usr/include/nspr4 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/libusb-1.0 -o config-temp/qemu-conf.exe config-temp/qemu-conf.c -Wl,-z,relro -Wl,-z,now -pie -m64 -g -L/home/berrange/src/external/libqnio/src -lqnio
In file included from config-temp/qemu-conf.c:2:0:
/home/berrange/src/external/libqnio/src/qnio/qnio_api.h:186:54: error: ‘struct iovec’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
int32_t iio_writev(void *apictx, int32_t rfd, struct iovec *iov, int iovcnt,
^~~~~
/home/berrange/src/external/libqnio/src/qnio/qnio_api.h:189:53: error: ‘struct iovec’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
int32_t iio_readv(void *apictx, int32_t rfd, struct iovec *iov, int iovcnt,
^~~~~
cc1: all warnings being treated as errors
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|
next prev parent reply other threads:[~2016-11-01 9:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-01 6:34 [Qemu-devel] [PATCH v5] block/vxhs.c Add support for a new block device type called "vxhs" Ashish Mittal
2016-11-01 9:07 ` Daniel P. Berrange [this message]
2016-11-01 16:09 ` ashish mittal
2016-11-01 16:27 ` Daniel P. Berrange
2016-11-01 16:52 ` ashish mittal
2016-11-01 17:08 ` Daniel P. Berrange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161101090741.GA11765@redhat.com \
--to=berrange@redhat.com \
--cc=Abhijit.Dey@veritas.com \
--cc=Buddhi.Madhav@veritas.com \
--cc=Ketan.Nilangekar@veritas.com \
--cc=Rakesh.Ranjan@veritas.com \
--cc=Venkatesha.Mg@veritas.com \
--cc=armbru@redhat.com \
--cc=ashish.mittal@veritas.com \
--cc=ashmit602@gmail.com \
--cc=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).