From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36210) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c1V2w-00077h-FQ for qemu-devel@nongnu.org; Tue, 01 Nov 2016 05:07:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c1V2s-0003cA-NI for qemu-devel@nongnu.org; Tue, 01 Nov 2016 05:07:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49130) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c1V2s-0003bu-G1 for qemu-devel@nongnu.org; Tue, 01 Nov 2016 05:07:50 -0400 Date: Tue, 1 Nov 2016 09:07:41 +0000 From: "Daniel P. Berrange" Message-ID: <20161101090741.GA11765@redhat.com> Reply-To: "Daniel P. Berrange" References: <1477982098-15462-1-git-send-email-ashish.mittal@veritas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1477982098-15462-1-git-send-email-ashish.mittal@veritas.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v5] block/vxhs.c Add support for a new block device type called "vxhs" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ashish Mittal Cc: qemu-devel@nongnu.org, pbonzini@redhat.com, kwolf@redhat.com, armbru@redhat.com, jcody@redhat.com, famz@redhat.com, ashish.mittal@veritas.com, stefanha@gmail.com, Rakesh.Ranjan@veritas.com, Buddhi.Madhav@veritas.com, Ketan.Nilangekar@veritas.com, Abhijit.Dey@veritas.com, Venkatesha.Mg@veritas.com On Mon, Oct 31, 2016 at 11:34:58PM -0700, Ashish Mittal wrote: > Source code for the qnio library that this code loads can be downloaded > from: > https://github.com/MittalAshish/libqnio.git Your patch is unable to compile against this, because the qnio_api.h header is using a "struct iovec" type in its APIs, but not including any header to define that type. This causes configure to fail cc -Werror -DHAS_LIBSSH2_SFTP_FSYNC -pthread -I/usr/include/glib-2.0 -I/u= sr/lib64/glib-2.0/include -D_GNU_SOURCE -fPIE -DPIE -m64 -mcx16 -D_GNU_SO= URCE -D_FILE_OFFSET_BITS=3D64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wr= edundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-st= rict-aliasing -fno-common -fwrapv -I/home/berrange/src/external/libqnio/s= rc -Wendif-labels -Wno-shift-negative-value -Wmissing-include-dirs -Wempt= y-body -Wnested-externs -Wformat-security -Wformat-y2k -Winit-self -Wigno= red-qualifiers -Wold-style-declaration -Wold-style-definition -Wtype-limi= ts -fstack-protector-strong -I/usr/include/p11-kit-1 -I/usr/include/libpn= g16 -I/usr/include/cacard -I/usr/include/nss3 -I/usr/include/nspr4 -I/usr= /include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/libusb-1.0= -o config-temp/qemu-conf.exe config-temp/qemu-conf.c -Wl,-z,relro -Wl,-z= ,now -pie -m64 -g -L/home/berrange/src/external/libqnio/src -lqnio In file included from config-temp/qemu-conf.c:2:0: /home/berrange/src/external/libqnio/src/qnio/qnio_api.h:186:54: error: =E2= =80=98struct iovec=E2=80=99 declared inside parameter list will not be vi= sible outside of this definition or declaration [-Werror] int32_t iio_writev(void *apictx, int32_t rfd, struct iovec *iov, int iov= cnt, ^~~~~ /home/berrange/src/external/libqnio/src/qnio/qnio_api.h:189:53: error: =E2= =80=98struct iovec=E2=80=99 declared inside parameter list will not be vi= sible outside of this definition or declaration [-Werror] int32_t iio_readv(void *apictx, int32_t rfd, struct iovec *iov, int iovc= nt, ^~~~~ cc1: all warnings being treated as errors Regards, Daniel --=20 |: http://berrange.com -o- http://www.flickr.com/photos/dberrange= / :| |: http://libvirt.org -o- http://virt-manager.or= g :| |: http://entangle-photo.org -o- http://search.cpan.org/~danberr= / :|