From: Wei Liu <wei.liu2@citrix.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
qemu-devel@nongnu.org, Xen-devel <xen-devel@lists.xenproject.org>,
Igor Mammedov <imammedo@redhat.com>,
Anthony PERARD <anthony.perard@citrix.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Sander Eikelenboom <linux@eikelenboom.it>
Subject: Re: [Qemu-devel] [PATCH RFC] PCMachineState: introduce acpi_build_enabled field
Date: Tue, 1 Nov 2016 17:12:37 +0000 [thread overview]
Message-ID: <20161101171237.GG30231@citrix.com> (raw)
In-Reply-To: <20161101170231.GB5057@thinpad.lan.raisama.net>
On Tue, Nov 01, 2016 at 03:02:31PM -0200, Eduardo Habkost wrote:
> On Tue, Nov 01, 2016 at 04:43:11PM +0000, Wei Liu wrote:
> [...]
> > @@ -114,6 +115,11 @@ static void xen_change_state_handler(void *opaque, int running,
> >
> > static int xen_init(MachineState *ms)
> > {
> > + PCMachineState *pcms = PC_MACHINE(ms);
> > +
> > + /* Disable ACPI build because Xen handles it */
> > + pcms->acpi_build_enabled = false;
>
> I just noticed that I don't see any code to disable ACPI build in
> the case of "-machine pc,accel=xen". I suggest a xen_enabled()
Hmm... I think this code snippet does exactly that -- xen_init is the
initialization function for Xen accelerator. So this covers -m xenfv
(because it sets accelerator to xen) and -m whatever,accel=xen.
Did I miss anything?
Wei.
next prev parent reply other threads:[~2016-11-01 17:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-01 16:43 [Qemu-devel] [PATCH RFC] PCMachineState: introduce acpi_build_enabled field Wei Liu
2016-11-01 16:48 ` Eduardo Habkost
2016-11-01 16:53 ` Wei Liu
2016-11-01 16:59 ` Eduardo Habkost
2016-11-01 17:01 ` Wei Liu
2016-11-01 17:02 ` Eduardo Habkost
2016-11-01 17:12 ` Wei Liu [this message]
2016-11-01 17:24 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161101171237.GG30231@citrix.com \
--to=wei.liu2@citrix.com \
--cc=anthony.perard@citrix.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=linux@eikelenboom.it \
--cc=qemu-devel@nongnu.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).