From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40366)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1c1bty-0007SA-6O
	for qemu-devel@nongnu.org; Tue, 01 Nov 2016 12:27:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1c1btv-0005s2-14
	for qemu-devel@nongnu.org; Tue, 01 Nov 2016 12:27:06 -0400
Received: from mx1.redhat.com ([209.132.183.28]:42040)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <imammedo@redhat.com>) id 1c1btu-0005rn-SQ
	for qemu-devel@nongnu.org; Tue, 01 Nov 2016 12:27:02 -0400
Date: Tue, 1 Nov 2016 17:26:59 +0100
From: Igor Mammedov <imammedo@redhat.com>
Message-ID: <20161101172659.3b89752b@nial.brq.redhat.com>
In-Reply-To: <4f9c3a31-973c-bf94-7a3b-5d39c293f761@linux.intel.com>
References: <1477850917-1214-1-git-send-email-mst@redhat.com>
	<1477850917-1214-38-git-send-email-mst@redhat.com>
	<20161031104518.7e423640@nial.brq.redhat.com>
	<46de99b0-8845-b324-1e5c-06b737fb45a6@linux.intel.com>
	<20161031120937.36d000b5@nial.brq.redhat.com>
	<ddf909c6-c3f8-d8c0-d679-a048c9a23a95@linux.intel.com>
	<20161101113526.1396cdd4@nial.brq.redhat.com>
	<d5006d18-4e44-e213-95e6-e18dba58dc06@linux.intel.com>
	<20161101145801.05d381ce@nial.brq.redhat.com>
	<4f9c3a31-973c-bf94-7a3b-5d39c293f761@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL 37/47] nvdimm acpi: introduce fit buffer
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Xiao Guangrong <guangrong.xiao@linux.intel.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, Richard Henderson <rth@twiddle.net>, qemu-devel@nongnu.org, Eduardo Habkost <ehabkost@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>

On Tue, 1 Nov 2016 23:57:55 +0800
Xiao Guangrong <guangrong.xiao@linux.intel.com> wrote:

> On 11/01/2016 09:58 PM, Igor Mammedov wrote:
> 
> >>
> >> I mean, for example. if there are two devices, the first one is failed to be
> >> realized, the second one is init-ed successfully, then can
> >> nvdimm_plugged_device_list() get these two devices?
> >>
> >> Based the code of pc_dimm_built_list(), i guess yes.  
> > nope,
> > read qdev_device_add() end result:
> >  - on success device in QOM tree
> >  - on failure device is destroyed  
> 
> Okay, pc_dimm_built_list let me mislead the failed case.
> so this function also can be refined.

pc_dimm_built_list() uses realized flag to get already present devices
and that's not what you need.