From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34103) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c1coy-0006Th-JI for qemu-devel@nongnu.org; Tue, 01 Nov 2016 13:26:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c1cox-00008L-JA for qemu-devel@nongnu.org; Tue, 01 Nov 2016 13:26:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49558) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c1cox-00007y-E0 for qemu-devel@nongnu.org; Tue, 01 Nov 2016 13:25:59 -0400 Date: Tue, 1 Nov 2016 19:25:57 +0200 From: "Michael S. Tsirkin" Message-ID: <20161101192359-mutt-send-email-mst@kernel.org> References: <1477850917-1214-1-git-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PULL 00/47] virtio, pc: fixes and features List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Developers On Tue, Nov 01, 2016 at 03:22:01PM +0000, Peter Maydell wrote: > On 30 October 2016 at 21:23, Michael S. Tsirkin wrote: > > The following changes since commit 5b2ecabaeabc17f032197246c4846b9ba95ba8a6: > > > > Merge remote-tracking branch 'remotes/kraxel/tags/pull-ui-20161028-1' into staging (2016-10-28 17:59:04 +0100) > > > > are available in the git repository at: > > > > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream > > > > for you to fetch changes up to f082ec0225bd15c71e0b4697d2df3af7bad65d7f: > > > > acpi: fix assert failure caused by commit 35c5a52d (2016-10-30 20:06:25 +0200) > > > > ---------------------------------------------------------------- > > virtio, pc: fixes and features > > > > nvdimm hotplug support > > virtio migration and ioeventfd rework > > virtio crypto device > > ipmi fixes > > > > Signed-off-by: Michael S. Tsirkin > > > > Hi; this fails to build on OSX with format string issues: > > /Users/pm215/src/qemu-for-merges/hw/virtio/virtio-crypto.c:770:20: > error: format specifies type 'unsign > ed short' but the argument has type 'uint32_t' (aka 'unsigned int') > [-Werror,-Wformat] > vcrypto->max_queues, VIRTIO_QUEUE_MAX); > ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > /Users/pm215/src/qemu-for-merges/include/qapi/error.h:163:35: note: > expanded from macro 'error_setg' > (fmt), ## __VA_ARGS__) > ^ > > Fun fact: in struct vhost_dev, max_queues is a uint64_t; > in struct VirtIONet it is a uint16_t; and in VirtIOCrypto > it is a uint32_t... > > thanks > -- PMM Yes - I really think we should move that to virtio core going forward. Anyway, I fixed that up and pushed. A general question - I have a couple of tweaks to tests in my tree. Didn't push to avoid them blocking the features. I think test tweaks are fair game after freeze - agree? -- MST