From: Kevin Wolf <kwolf@redhat.com>
To: ashish mittal <ashmit602@gmail.com>
Cc: "Daniel P. Berrange" <berrange@redhat.com>,
Eric Blake <eblake@redhat.com>,
qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Jeff Cody <jcody@redhat.com>,
famz@redhat.com, Ashish Mittal <ashish.mittal@veritas.com>,
Stefan Hajnoczi <stefanha@gmail.com>,
Rakesh Ranjan <Rakesh.Ranjan@veritas.com>,
Buddhi.Madhav@veritas.com, Ketan.Nilangekar@veritas.com,
Abhijit.Dey@veritas.com, Venkatesha.Mg@veritas.com
Subject: Re: [Qemu-devel] [PATCH v3] block/vxhs: Add Veritas HyperScale VxHS block device support
Date: Wed, 2 Nov 2016 10:57:38 +0100 [thread overview]
Message-ID: <20161102095738.GA6182@noname.redhat.com> (raw)
In-Reply-To: <CAAo6VWMeWoQV_o8OZfLLfGE+wmOQbLL6EzK4CDEEJ1+80mk26A@mail.gmail.com>
Am 01.11.2016 um 05:03 hat ashish mittal geschrieben:
> >> >> +##
> >> >> +{ 'struct': 'BlockdevOptionsVxHS',
> >> >> + 'data': { 'vdisk_id': 'str',
> >> >> + 'server': 'InetSocketAddress' } }
> >> >
> >> > Is there any way to use a Unix socket, or is this server ONLY accessible
> >> > over IPv4/IPv6?
> >> >
> >>
> >> Right now we support IPv4 only.
> >
> > IMHO it should allow use of UNIX sockets, as its possible to have
> > SSH setup a tunnel to a IP server, and expose the endpoint via a
> > UNIX socket. So even if your reference server only supports IPv4,
> > users can conceivably connect with any sockets protocol.
> >
>
> This is not a use-case that we have in mind right now, but a very fair
> point! Kind of like accessing the audio/video streams remotely from my
> Raspberry Pi over ssh. Is it OK if we target this in a future patch
> after proper review/testing?
No, going from InetSocketAddress to SocketAddress changes the API in an
incompatible way (previously working blockdev-add commands would stop
working), so we must decide now before the API is introduced.
Kevin
next prev parent reply other threads:[~2016-11-02 9:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-28 7:44 [Qemu-devel] [PATCH v3] block/vxhs: Add Veritas HyperScale VxHS block device support Ashish Mittal
2016-10-28 14:44 ` Eric Blake
2016-10-28 21:30 ` ashish mittal
2016-10-31 10:55 ` Daniel P. Berrange
2016-11-01 4:03 ` ashish mittal
2016-11-02 9:57 ` Kevin Wolf [this message]
2016-11-02 14:13 ` Eric Blake
2016-11-02 15:02 ` Kevin Wolf
2016-11-02 16:41 ` ashish mittal
2016-10-28 19:03 ` Jeff Cody
2016-10-28 21:58 ` Buddhi Madhav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161102095738.GA6182@noname.redhat.com \
--to=kwolf@redhat.com \
--cc=Abhijit.Dey@veritas.com \
--cc=Buddhi.Madhav@veritas.com \
--cc=Ketan.Nilangekar@veritas.com \
--cc=Rakesh.Ranjan@veritas.com \
--cc=Venkatesha.Mg@veritas.com \
--cc=armbru@redhat.com \
--cc=ashish.mittal@veritas.com \
--cc=ashmit602@gmail.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).