From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56254) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c1sIl-0000xM-WE for qemu-devel@nongnu.org; Wed, 02 Nov 2016 05:57:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c1sIi-0006bJ-3w for qemu-devel@nongnu.org; Wed, 02 Nov 2016 05:57:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32912) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c1sIh-0006ao-Uy for qemu-devel@nongnu.org; Wed, 02 Nov 2016 05:57:44 -0400 Date: Wed, 2 Nov 2016 10:57:38 +0100 From: Kevin Wolf Message-ID: <20161102095738.GA6182@noname.redhat.com> References: <1477640667-4775-1-git-send-email-ashish.mittal@veritas.com> <7179b840-077d-a06f-e2ab-4da711029cfd@redhat.com> <20161031105509.GC2668@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v3] block/vxhs: Add Veritas HyperScale VxHS block device support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: ashish mittal Cc: "Daniel P. Berrange" , Eric Blake , qemu-devel@nongnu.org, Paolo Bonzini , Markus Armbruster , Jeff Cody , famz@redhat.com, Ashish Mittal , Stefan Hajnoczi , Rakesh Ranjan , Buddhi.Madhav@veritas.com, Ketan.Nilangekar@veritas.com, Abhijit.Dey@veritas.com, Venkatesha.Mg@veritas.com Am 01.11.2016 um 05:03 hat ashish mittal geschrieben: > >> >> +## > >> >> +{ 'struct': 'BlockdevOptionsVxHS', > >> >> + 'data': { 'vdisk_id': 'str', > >> >> + 'server': 'InetSocketAddress' } } > >> > > >> > Is there any way to use a Unix socket, or is this server ONLY accessible > >> > over IPv4/IPv6? > >> > > >> > >> Right now we support IPv4 only. > > > > IMHO it should allow use of UNIX sockets, as its possible to have > > SSH setup a tunnel to a IP server, and expose the endpoint via a > > UNIX socket. So even if your reference server only supports IPv4, > > users can conceivably connect with any sockets protocol. > > > > This is not a use-case that we have in mind right now, but a very fair > point! Kind of like accessing the audio/video streams remotely from my > Raspberry Pi over ssh. Is it OK if we target this in a future patch > after proper review/testing? No, going from InetSocketAddress to SocketAddress changes the API in an incompatible way (previously working blockdev-add commands would stop working), so we must decide now before the API is introduced. Kevin