From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42773) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c1rXj-0005kx-0U for qemu-devel@nongnu.org; Wed, 02 Nov 2016 05:09:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c1rXf-00007c-PP for qemu-devel@nongnu.org; Wed, 02 Nov 2016 05:09:10 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:34797 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c1rXf-00007B-Kz for qemu-devel@nongnu.org; Wed, 02 Nov 2016 05:09:07 -0400 Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id uA298qfm030269 for ; Wed, 2 Nov 2016 05:09:06 -0400 Received: from e06smtp14.uk.ibm.com (e06smtp14.uk.ibm.com [195.75.94.110]) by mx0a-001b2d01.pphosted.com with ESMTP id 26f9r5d50d-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Wed, 02 Nov 2016 05:09:06 -0400 Received: from localhost by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 2 Nov 2016 09:09:04 -0000 Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id D67AE2190056 for ; Wed, 2 Nov 2016 09:08:17 +0000 (GMT) Received: from d06av03.portsmouth.uk.ibm.com (d06av03.portsmouth.uk.ibm.com [9.149.37.213]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id uA2992Kb30343184 for ; Wed, 2 Nov 2016 09:09:02 GMT Received: from d06av03.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av03.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id uA2992KC016370 for ; Wed, 2 Nov 2016 03:09:02 -0600 Date: Wed, 2 Nov 2016 10:09:00 +0100 From: Cornelia Huck In-Reply-To: <20161031153929.GK11941@var.home> References: <1477656698-13569-1-git-send-email-kraxel@redhat.com> <1477656698-13569-7-git-send-email-kraxel@redhat.com> <20161031124530.2aad6ed6.cornelia.huck@de.ibm.com> <20161031120159.GH3671@var.home> <20161031130806.272eef44.cornelia.huck@de.ibm.com> <20161031123930.GM3671@var.home> <20161031134801.49697f92.cornelia.huck@de.ibm.com> <20161031140333.GA4298@var.eduroam.u-bordeaux.fr> <20161031140848.68bdc709.cornelia.huck@de.ibm.com> <20161031153929.GK11941@var.home> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Message-Id: <20161102100900.3fd97bff.cornelia.huck@de.ibm.com> Subject: Re: [Qemu-devel] [PULL 6/6] curses: Use cursesw instead of curses List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Samuel Thibault Cc: Gerd Hoffmann , qemu-devel@nongnu.org On Mon, 31 Oct 2016 16:39:29 +0100 Samuel Thibault wrote: > Cornelia Huck, on Mon 31 Oct 2016 14:08:48 +0100, wrote: > > On Mon, 31 Oct 2016 15:03:33 +0100 > > Samuel Thibault wrote: > >=20 > > > Cornelia Huck, on Mon 31 Oct 2016 13:48:01 +0100, wrote: > > > > On Mon, 31 Oct 2016 13:39:30 +0100 > > > > Samuel Thibault wrote: > > > >=20 > > > > > Cornelia Huck, on Mon 31 Oct 2016 13:08:06 +0100, wrote: > > > > > > You mean in configure, right? Including cursesw.h in the test p= rogram > > > > > > gets configure going again. > > > > >=20 > > > > > Could you try the attached patch which fixes both configure and > > > > > ui/curses.c? > > > >=20 > > > > Sadly, this does not fix it for me. I get the same errors in the > > > > configure test build as before. > > >=20 > > > Could you post the config.log so we get a better view at what is going > > > wrong? > >=20 > > Attached. >=20 > > cc -m64 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=3D64 -D_LARGEFILE_SOURCE -Wst= rict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-p= rototypes -fno-strict-aliasing -fno-common -fwrapv -Wendif-labels -Wmissing= -include-dirs -Wempty-body -Wnested-externs -Wformat-security -Wformat-y2k = -Winit-self -Wignored-qualifiers -Wold-style-declaration -Wold-style-defini= tion -Wtype-limits -fstack-protector-all -I/usr/include/libpng16 -o config-= temp/qemu-conf.exe config-temp/qemu-conf.c -m64 -g > > config-temp/qemu-conf.c: In function =E2=80=98main=E2=80=99: > > config-temp/qemu-conf.c:13:3: warning: implicit declaration of function= =E2=80=98addwstr=E2=80=99 [-Wimplicit-function-declaration] > ... > > cc -m64 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=3D64 -D_LARGEFILE_SOURCE -Wst= rict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-p= rototypes -fno-strict-aliasing -fno-common -fwrapv -Wendif-labels -Wmissing= -include-dirs -Wempty-body -Wnested-externs -Wformat-security -Wformat-y2k = -Winit-self -Wignored-qualifiers -Wold-style-declaration -Wold-style-defini= tion -Wtype-limits -fstack-protector-all -I/usr/include/libpng16 -o config-= temp/qemu-conf.exe config-temp/qemu-conf.c -m64 -g -lncursesw > > config-temp/qemu-conf.c: In function =E2=80=98main=E2=80=99: > > config-temp/qemu-conf.c:13:3: warning: implicit declaration of function= =E2=80=98addwstr=E2=80=99 [-Wimplicit-function-declaration] > ... > > cc -Werror -m64 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=3D64 -D_LARGEFILE_SOU= RCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wm= issing-prototypes -fno-strict-aliasing -fno-common -fwrapv -Wendif-labels -= Wmissing-include-dirs -Wempty-body -Wnested-externs -Wformat-security -Wfor= mat-y2k -Winit-self -Wignored-qualifiers -Wold-style-declaration -Wold-styl= e-definition -Wtype-limits -fstack-protector-all -I/usr/include/libpng16 -o= config-temp/qemu-conf.exe config-temp/qemu-conf.c -m64 -g -lncursesw > > config-temp/qemu-conf.c: In function =E2=80=98main=E2=80=99: > > config-temp/qemu-conf.c:13:3: error: implicit declaration of function = =E2=80=98addwstr=E2=80=99 [-Werror=3Dimplicit-function-declaration] > > addwstr(L"wide chars\n"); > > ^ > > config-temp/qemu-conf.c:13:3: error: nested extern declaration of =E2= =80=98addwstr=E2=80=99 [-Werror=3Dnested-externs] > > config-temp/qemu-conf.c:14:3: error: implicit declaration of function = =E2=80=98addnwstr=E2=80=99 [-Werror=3Dimplicit-function-declaration] > > addnwstr(&wch, 1); > > ^ > > config-temp/qemu-conf.c:14:3: error: nested extern declaration of =E2= =80=98addnwstr=E2=80=99 [-Werror=3Dnested-externs] > > cc1: all warnings being treated as errors >=20 > These are expected >=20 > But doesn't configure also try with -DCONFIG_CURSESW_H? Does it really > stop here? Nothing more going on there. Maybe it is because it cannot pull the relevant flags from pkg_config?