* [Qemu-devel] [PATCH v2] block/ssh: Code cleanup for unused parameter
@ 2016-11-02 10:53 Ashijeet Acharya
2016-11-02 11:16 ` Kevin Wolf
0 siblings, 1 reply; 2+ messages in thread
From: Ashijeet Acharya @ 2016-11-02 10:53 UTC (permalink / raw)
To: kwolf; +Cc: mreitz, rjones, jcody, qemu-devel, qemu-block, Ashijeet Acharya
This patch drops the unused parameter "BDRVSSHState" being passed into
the ssh_config() function and does code cleanup. The unused parameter
was introduced by the commit c322712.
Signed-off-by: Ashijeet Acharya <ashijeetacharya@gmail.com>
---
Changes in v2:
- Modify the commit message and subject line
---
block/ssh.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/block/ssh.c b/block/ssh.c
index ca071c5..15ed281 100644
--- a/block/ssh.c
+++ b/block/ssh.c
@@ -582,8 +582,7 @@ static bool ssh_process_legacy_socket_options(QDict *output_opts,
return true;
}
-static InetSocketAddress *ssh_config(BDRVSSHState *s, QDict *options,
- Error **errp)
+static InetSocketAddress *ssh_config(QDict *options, Error **errp)
{
InetSocketAddress *inet = NULL;
QDict *addr = NULL;
@@ -661,7 +660,7 @@ static int connect_to_ssh(BDRVSSHState *s, QDict *options,
}
/* Pop the config into our state object, Exit if invalid */
- s->inet = ssh_config(s, options, errp);
+ s->inet = ssh_config(options, errp);
if (!s->inet) {
ret = -EINVAL;
goto err;
--
2.6.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-11-02 11:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-02 10:53 [Qemu-devel] [PATCH v2] block/ssh: Code cleanup for unused parameter Ashijeet Acharya
2016-11-02 11:16 ` Kevin Wolf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).