From: Kevin Wolf <kwolf@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: qemu-block@nongnu.org, hpoussin@reactos.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 0/3] atapi: classify read_cd as conditionally returning data
Date: Wed, 2 Nov 2016 14:36:03 +0100 [thread overview]
Message-ID: <20161102133603.GH6182@noname.redhat.com> (raw)
In-Reply-To: <1477970211-25754-1-git-send-email-jsnow@redhat.com>
Am 01.11.2016 um 04:16 hat John Snow geschrieben:
> v2:
> - Actually applied the changes this time ...
> - And added a test to the AHCI suite...
> - ...Which revealed a few small issues in the suite.
>
> The AHCI test should be sufficient in terms of general proof
> for ATAPI regardless of the HBA used.
As I commented, I think patch 3 includes a silent bug fix, so maybe
check whether you agree with my understanding of the code and consider
to make this more explicit. In any case, I think it's still correct:
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
next prev parent reply other threads:[~2016-11-02 13:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-01 3:16 [Qemu-devel] [PATCH v2 0/3] atapi: classify read_cd as conditionally returning data John Snow
2016-11-01 3:16 ` [Qemu-devel] [PATCH v2 1/3] " John Snow
2016-11-01 3:16 ` [Qemu-devel] [PATCH v2 2/3] ahci-test: Create smaller test ISO images John Snow
2016-11-01 3:16 ` [Qemu-devel] [PATCH v2 3/3] ahci-test: test atapi read_cd with bcl, nb_sectors = 0 John Snow
2016-11-02 13:33 ` Kevin Wolf
2016-11-02 15:01 ` John Snow
2016-11-02 15:56 ` Kevin Wolf
2016-11-01 3:23 ` [Qemu-devel] [PATCH v2 0/3] atapi: classify read_cd as conditionally returning data no-reply
2016-11-02 13:36 ` Kevin Wolf [this message]
2016-11-02 18:31 ` John Snow
2016-11-02 19:49 ` Hervé Poussineau
2016-11-02 20:20 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161102133603.GH6182@noname.redhat.com \
--to=kwolf@redhat.com \
--cc=hpoussin@reactos.org \
--cc=jsnow@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).