From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60770) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c1zlV-0001Y5-Tm for qemu-devel@nongnu.org; Wed, 02 Nov 2016 13:55:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c1zlS-0001FC-41 for qemu-devel@nongnu.org; Wed, 02 Nov 2016 13:55:58 -0400 From: Max Reitz Date: Wed, 2 Nov 2016 18:55:36 +0100 Message-Id: <20161102175539.4375-1-mreitz@redhat.com> Subject: [Qemu-devel] [PATCH for-2.8? 0/3] block/curl: Drop TFTP "support" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, Max Reitz , Jeff Cody , Kevin Wolf , Markus Armbruster , Eric Blake See patch 3 for the reason why we have actually never supported TFTP at all (except for very small files (i.e. below 256 kB or so)). I would consider this series a bug fix because, well, it doesn't really change any functionality, and the bug is "We don't support TFTP but we pretend we do". Alternatives to this approach: - Deprecate TFTP first. Wait one version, then drop it. We could do this, but I personally don't think it's necessary. We have done this for host_floppy, but in contrast to host_floppy, TFTP really has never worked. Thus, I conclude that nobody is actually using it or has ever used it for real work. Still, if you think otherwise, we can still do this, of course. - Don't remove TFTP altogether, but just emit a run-time error like we do for HTTP servers that do not support range-based requests. Seems dirty and not like the real solution to me. Also, we have removed other block drivers in the past, so I don't think we should keep TFTP. Max Reitz (3): qemu-options: Drop mentions of curl's TFTP support qapi: Drop curl's TFTP protocol block/curl: Drop TFTP "support" block/curl.c | 20 +------------------- docs/qmp-commands.txt | 2 +- qapi/block-core.json | 7 +++---- qemu-options.hx | 6 +++--- 4 files changed, 8 insertions(+), 27 deletions(-) -- 2.10.2