From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45964) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c29Pv-00028P-EW for qemu-devel@nongnu.org; Thu, 03 Nov 2016 00:14:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c29Pr-0005WI-MV for qemu-devel@nongnu.org; Thu, 03 Nov 2016 00:14:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34308) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c29Pr-0005W4-GO for qemu-devel@nongnu.org; Thu, 03 Nov 2016 00:14:15 -0400 Date: Thu, 3 Nov 2016 06:14:11 +0200 From: "Michael S. Tsirkin" Message-ID: <20161103061348-mutt-send-email-mst@kernel.org> References: <1478145090-11987-1-git-send-email-guangrong.xiao@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1478145090-11987-1-git-send-email-guangrong.xiao@linux.intel.com> Subject: Re: [Qemu-devel] [PATCH v4 0/3] nvdimm: hotplug support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Xiao Guangrong Cc: pbonzini@redhat.com, imammedo@redhat.com, gleb@kernel.org, mtosatti@redhat.com, stefanha@redhat.com, rth@twiddle.net, ehabkost@redhat.com, dan.j.williams@intel.com, kvm@vger.kernel.org, qemu-devel@nongnu.org On Thu, Nov 03, 2016 at 11:51:27AM +0800, Xiao Guangrong wrote: > Resend these 3 patches to catch up release window... > > Igor, > > this is a open that i did not pass a buffer as parameter to RFIT as > tried the way you suggested, but failed. May be i am not very good at > ASL, i need more time to try. So let's keep the way as it is, i will > improve it later. > > Thanks! And just for comparison, could you pls generate the incremental diff as well? > Changelog in v4: > 1) drop fit lock and post_hotplug_cb > 2) move nvdimm hotplug code to hw/acpi/nvdimm.c > 3) introduce length field to indicate the fit size > 4) nvdimm acpi cleanup > 5) doc typo fixes > > Changelog in v3: > 1) use a dedicated interrupt for nvdimm device hotplug > 2) stop nvdimm device hot unplug > 3) reserve UUID and handle for QEMU internally used QEMU > 5) redesign fit buffer to avoid OSPM reading incomplete fit info > 6) bug fixes and cleanups > > Changelog in v2: > Fixed signed integer overflow pointed out by Stefan Hajnoczi > > This patchset enables nvdimm hotplug support, it is used as pc-dimm hotplug, > for example, a new nvdimm device can be plugged as follows: > object_add memory-backend-file,id=mem3,size=10G,mem-path=/home/eric/nvdimm3 > device_add nvdimm,id=nvdimm3,memdev=mem3 > > and unplug it as follows: > device_del nvdimm3 > > Xiao Guangrong (3): > nvdimm acpi: introduce fit buffer > nvdimm acpi: introduce _FIT > pc: memhp: enable nvdimm device hotplug > > default-configs/mips-softmmu-common.mak | 1 + > docs/specs/acpi_nvdimm.txt | 68 +++++++- > hw/acpi/ich9.c | 8 +- > hw/acpi/nvdimm.c | 289 ++++++++++++++++++++++++++++---- > hw/acpi/piix4.c | 7 +- > hw/i386/acpi-build.c | 9 +- > hw/i386/pc.c | 16 ++ > hw/mem/nvdimm.c | 4 - > include/hw/acpi/acpi_dev_interface.h | 1 + > include/hw/mem/nvdimm.h | 22 ++- > 10 files changed, 377 insertions(+), 48 deletions(-) > > -- > 1.8.3.1