From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33514) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c2EY0-0007TP-3h for qemu-devel@nongnu.org; Thu, 03 Nov 2016 05:43:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c2EXz-00025n-Et for qemu-devel@nongnu.org; Thu, 03 Nov 2016 05:43:00 -0400 Date: Thu, 3 Nov 2016 10:42:49 +0100 From: Kevin Wolf Message-ID: <20161103094249.GA5352@noname.redhat.com> References: <20161102175539.4375-1-mreitz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161102175539.4375-1-mreitz@redhat.com> Subject: Re: [Qemu-devel] [PATCH for-2.8? 0/3] block/curl: Drop TFTP "support" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, Jeff Cody , Markus Armbruster , Eric Blake Am 02.11.2016 um 18:55 hat Max Reitz geschrieben: > See patch 3 for the reason why we have actually never supported TFTP at > all (except for very small files (i.e. below 256 kB or so)). > > I would consider this series a bug fix because, well, it doesn't really > change any functionality, and the bug is "We don't support TFTP but we > pretend we do". Reviewed-by: Kevin Wolf libvirt added support for tftp in commit 8ffe1d0c, in a series that added https and ftps, too. I suppose tftp wasn't actually tested. Maybe libvirt wants to remove tftp as well. Kevin