From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36943) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c2Eif-0003IX-DH for qemu-devel@nongnu.org; Thu, 03 Nov 2016 05:54:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c2Eib-0007Ss-Hv for qemu-devel@nongnu.org; Thu, 03 Nov 2016 05:54:01 -0400 Received: from mail-wm0-x242.google.com ([2a00:1450:400c:c09::242]:34412) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c2Eib-0007S8-AB for qemu-devel@nongnu.org; Thu, 03 Nov 2016 05:53:57 -0400 Received: by mail-wm0-x242.google.com with SMTP id p190so7116964wmp.1 for ; Thu, 03 Nov 2016 02:53:57 -0700 (PDT) Date: Thu, 3 Nov 2016 09:53:53 +0000 From: Stefan Hajnoczi Message-ID: <20161103095353.GA5154@stefanha-x1.localdomain> References: <1478145090-11987-1-git-send-email-guangrong.xiao@linux.intel.com> <1478145090-11987-3-git-send-email-guangrong.xiao@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="IS0zKkzwUGydFO0o" Content-Disposition: inline In-Reply-To: <1478145090-11987-3-git-send-email-guangrong.xiao@linux.intel.com> Subject: Re: [Qemu-devel] [PATCH v4 2/3] nvdimm acpi: introduce _FIT List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Xiao Guangrong Cc: pbonzini@redhat.com, imammedo@redhat.com, gleb@kernel.org, mtosatti@redhat.com, stefanha@redhat.com, mst@redhat.com, rth@twiddle.net, ehabkost@redhat.com, dan.j.williams@intel.com, kvm@vger.kernel.org, qemu-devel@nongnu.org --IS0zKkzwUGydFO0o Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 03, 2016 at 11:51:29AM +0800, Xiao Guangrong wrote: > @@ -504,6 +521,77 @@ nvdimm_dsm_no_payload(uint32_t func_ret_status, hwad= dr dsm_mem_addr) > cpu_physical_memory_write(dsm_mem_addr, &out, sizeof(out)); > } > =20 > +#define NVDIMM_DSM_RET_STATUS_SUCCESS 0 /* Success */ > +#define NVDIMM_DSM_RET_STATUS_UNSUPPORT 1 /* Not Supported */ > +#define NVDIMM_DSM_RET_STATUS_INVALID 3 /* Invalid Input Paramete= rs */ Not worth changing but please make each logical change a separate patch in the future. This patch is cluttered with NVDIMM_DSM_RET_STATUS_ constant renaming. It's easier to review, bisect, and backport when structured as separate patches. --IS0zKkzwUGydFO0o Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJYGwkxAAoJEJykq7OBq3PIAVgH/jNRx41OcpsDIg/8d3FJkjTu Es5MWbkkoBvNwy/au1FZ/pj53YRzG09+rZG8WfVE7bK2iVkbRo+6q0CHi162+1QD E2wgKaz74/KtAuMbFIvfmdrU0MBm0DcVmCQB8v60I1whjya/6HnbuLVAIBdK3Khh yzJ9b5ZcBosiy5gFPLKenXLYm9n9/fVyjw8ArICbYS716bEwF0xhOxEMyuz3L7FE SgSMM23Wop3LntDEpkFGV3iLNkm7SLjnghT/xe0l06XwcqFoiNOyNUuKfTcNr/Fz YAdEFsqFnBz1VTV4FX5p8e4bp8cgTFs3E8e0ADQUTnHyrUmXTBu/S9IO6tuEwyY= =Zx2w -----END PGP SIGNATURE----- --IS0zKkzwUGydFO0o--