From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37989) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c2Eoo-0004jf-QE for qemu-devel@nongnu.org; Thu, 03 Nov 2016 06:00:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c2Eok-0002l5-Uj for qemu-devel@nongnu.org; Thu, 03 Nov 2016 06:00:22 -0400 Received: from mail-wm0-x232.google.com ([2a00:1450:400c:c09::232]:35781) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c2Eok-0002kw-NQ for qemu-devel@nongnu.org; Thu, 03 Nov 2016 06:00:18 -0400 Received: by mail-wm0-x232.google.com with SMTP id a197so193538727wmd.0 for ; Thu, 03 Nov 2016 03:00:18 -0700 (PDT) Date: Thu, 3 Nov 2016 10:00:15 +0000 From: Stefan Hajnoczi Message-ID: <20161103100015.GB5154@stefanha-x1.localdomain> References: <1478145090-11987-1-git-send-email-guangrong.xiao@linux.intel.com> <1478145090-11987-2-git-send-email-guangrong.xiao@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="dTy3Mrz/UPE2dbVg" Content-Disposition: inline In-Reply-To: <1478145090-11987-2-git-send-email-guangrong.xiao@linux.intel.com> Subject: Re: [Qemu-devel] [PATCH v4 1/3] nvdimm acpi: introduce fit buffer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Xiao Guangrong Cc: pbonzini@redhat.com, imammedo@redhat.com, gleb@kernel.org, mtosatti@redhat.com, stefanha@redhat.com, mst@redhat.com, rth@twiddle.net, ehabkost@redhat.com, dan.j.williams@intel.com, kvm@vger.kernel.org, qemu-devel@nongnu.org --dTy3Mrz/UPE2dbVg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Nov 03, 2016 at 11:51:28AM +0800, Xiao Guangrong wrote: > +static void nvdimm_init_fit_buffer(NvdimmFitBuffer *fit_buf) > +{ > + fit_buf->fit = g_array_new(false, true /* clear */, 1); > +} > + > +static void nvdimm_build_fit_buffer(NvdimmFitBuffer *fit_buf) > +{ > + g_array_free(fit_buf->fit, true); > + fit_buf->fit = nvdimm_build_device_structure(); In the previous revision I pointed out that it's messy to inline g_array_new(false, true /* clear */, 1) in nvdimm_init_fit_buffer() when the data structure is normally created by nvdimm_build_device_structure(). You didn't respond. Is it possible to call nvdimm_build_device_structure() in nvdimm_init_fit_buffer() so we don't need to duplicate the details of how the GArray is created? --dTy3Mrz/UPE2dbVg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJYGwqvAAoJEJykq7OBq3PI4aMH/1kNPqpclYbR/lT1M34NkFXO TdFho9xjtPuI8LfEUa7GjFBv1rctfoLN7dq8o4X5IFmxCY7d4k+7o3pVtD3czfWS yMGoLcwL39nEh1+Tt/WQO00bEL+DeFLXeiM+udQLwgdH07QLKyGNqAbMlyL+EC2n n+8Xj/Aes1MHsxbIh2P3WV/DwXnA/U7d11eX7rB1NJbOAhhqdKa/c6rX4nOCqigO SdfOG0Fte0yyx8XE95C5FskV2LEVMz/eDqcaJsj+437tsG1h9kbrsgqqwVqBHn6U 8YGDZIVzjR8LL0aWTm7d5cP9l6zJ6rTdMBcaR+CPANCWazDiGOZVcBV+8btXOss= =ltzj -----END PGP SIGNATURE----- --dTy3Mrz/UPE2dbVg--