qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Alberto Garcia <berto@igalia.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] hmp: Make block_stream set an explicit job ID
Date: Fri, 4 Nov 2016 15:06:46 +0100	[thread overview]
Message-ID: <20161104140646.GD5418@noname.redhat.com> (raw)
In-Reply-To: <20161104134443.28686-1-berto@igalia.com>

Am 04.11.2016 um 14:44 hat Alberto Garcia geschrieben:
> A job ID is always required in order to create a block job on a
> non-root node. The default ID (obtained with bdrv_get_device_name())
> is otherwise empty in this scenario and the job cannot be created.
> 
> The HMP block_stream command doesn't set a job ID and therefore it
> doesn't allow streaming to intermediate nodes. One solution is to add
> an extra parameter to set a job ID. The other solution is to simply
> use the node name passed to block_stream as job ID. This won't work
> if it's automatically generated (because it contains a '#') but is
> otherwise simple enough for all other cases.
> 
> This way 'block_stream node3' will create a job with the ID 'node3'
> and the good old 'block_stream virtio0' will keep the previous
> behaviour and use 'virtio0' for the job ID.
> 
> Signed-off-by: Alberto Garcia <berto@igalia.com>

Thanks, applied to the block branch.

Kevin

      reply	other threads:[~2016-11-04 14:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-04 13:44 [Qemu-devel] [PATCH] hmp: Make block_stream set an explicit job ID Alberto Garcia
2016-11-04 14:06 ` Kevin Wolf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161104140646.GD5418@noname.redhat.com \
    --to=kwolf@redhat.com \
    --cc=berto@igalia.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).