From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52620) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c2f98-000859-8b for qemu-devel@nongnu.org; Fri, 04 Nov 2016 10:07:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c2f94-00029z-4s for qemu-devel@nongnu.org; Fri, 04 Nov 2016 10:07:06 -0400 Date: Fri, 4 Nov 2016 15:06:46 +0100 From: Kevin Wolf Message-ID: <20161104140646.GD5418@noname.redhat.com> References: <20161104134443.28686-1-berto@igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161104134443.28686-1-berto@igalia.com> Subject: Re: [Qemu-devel] [PATCH] hmp: Make block_stream set an explicit job ID List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alberto Garcia Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org Am 04.11.2016 um 14:44 hat Alberto Garcia geschrieben: > A job ID is always required in order to create a block job on a > non-root node. The default ID (obtained with bdrv_get_device_name()) > is otherwise empty in this scenario and the job cannot be created. > > The HMP block_stream command doesn't set a job ID and therefore it > doesn't allow streaming to intermediate nodes. One solution is to add > an extra parameter to set a job ID. The other solution is to simply > use the node name passed to block_stream as job ID. This won't work > if it's automatically generated (because it contains a '#') but is > otherwise simple enough for all other cases. > > This way 'block_stream node3' will create a job with the ID 'node3' > and the good old 'block_stream virtio0' will keep the previous > behaviour and use 'virtio0' for the job ID. > > Signed-off-by: Alberto Garcia Thanks, applied to the block branch. Kevin