* [Qemu-devel] [PATCH] qcow2: Remove stale FIXME comment
@ 2016-11-04 15:00 Alberto Garcia
2016-11-04 15:30 ` Kevin Wolf
0 siblings, 1 reply; 3+ messages in thread
From: Alberto Garcia @ 2016-11-04 15:00 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-block, Kevin Wolf, Alberto Garcia
It was from the time when none of the global functions had a qcow2_
prefix.
Signed-off-by: Alberto Garcia <berto@igalia.com>
---
block/qcow2.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/block/qcow2.h b/block/qcow2.h
index 92203a8..1823414 100644
--- a/block/qcow2.h
+++ b/block/qcow2.h
@@ -473,8 +473,6 @@ static inline uint64_t refcount_diff(uint64_t r1, uint64_t r2)
return r1 > r2 ? r1 - r2 : r2 - r1;
}
-// FIXME Need qcow2_ prefix to global functions
-
/* qcow2.c functions */
int qcow2_backing_read1(BlockDriverState *bs, QEMUIOVector *qiov,
int64_t sector_num, int nb_sectors);
--
2.10.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] qcow2: Remove stale FIXME comment
2016-11-04 15:00 [Qemu-devel] [PATCH] qcow2: Remove stale FIXME comment Alberto Garcia
@ 2016-11-04 15:30 ` Kevin Wolf
2016-11-04 15:31 ` Kevin Wolf
0 siblings, 1 reply; 3+ messages in thread
From: Kevin Wolf @ 2016-11-04 15:30 UTC (permalink / raw)
To: Alberto Garcia; +Cc: qemu-devel, qemu-block
Am 04.11.2016 um 16:00 hat Alberto Garcia geschrieben:
> It was from the time when none of the global functions had a qcow2_
> prefix.
>
> Signed-off-by: Alberto Garcia <berto@igalia.com>
Thanks, applied to the block layer.
Kevin
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] qcow2: Remove stale FIXME comment
2016-11-04 15:30 ` Kevin Wolf
@ 2016-11-04 15:31 ` Kevin Wolf
0 siblings, 0 replies; 3+ messages in thread
From: Kevin Wolf @ 2016-11-04 15:31 UTC (permalink / raw)
To: Alberto Garcia; +Cc: qemu-devel, qemu-block
Am 04.11.2016 um 16:30 hat Kevin Wolf geschrieben:
> Am 04.11.2016 um 16:00 hat Alberto Garcia geschrieben:
> > It was from the time when none of the global functions had a qcow2_
> > prefix.
> >
> > Signed-off-by: Alberto Garcia <berto@igalia.com>
>
> Thanks, applied to the block layer.
The block branch, obviously...
Kevin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-11-04 15:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-04 15:00 [Qemu-devel] [PATCH] qcow2: Remove stale FIXME comment Alberto Garcia
2016-11-04 15:30 ` Kevin Wolf
2016-11-04 15:31 ` Kevin Wolf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).